This repository was archived by the owner on Feb 21, 2026. It is now read-only.
[Services] Add searxng and migrate to AbstractWebSearchService#1698
Closed
Herklos wants to merge 1 commit into
Closed
[Services] Add searxng and migrate to AbstractWebSearchService#1698Herklos wants to merge 1 commit into
Herklos wants to merge 1 commit into
Conversation
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "version": "1.0.0", | |||
Member
There was a problem hiding this comment.
Suggested change
| "version": "1.0.0", | |
| "version": "1.2.0", |
| return {} | ||
|
|
||
| try: | ||
| async with aiohttp.ClientSession() as session: |
Member
There was a problem hiding this comment.
if possible, we should store this session somewhere to avoid re-creating it at every request
| return {} | ||
| return await resp.json() | ||
| except aiohttp.ClientError as e: | ||
| if self.logger: |
Member
There was a problem hiding this comment.
I think we should not check if self.logger exists
| return await resp.json() | ||
| except aiohttp.ClientError as e: | ||
| if self.logger: | ||
| self.logger.error(f"SearXNG API request failed: {e}") |
Member
There was a problem hiding this comment.
Suggested change
| self.logger.error(f"SearXNG API request failed: {e}") | |
| self.logger.exception(e, True, f"SearXNG API request failed: {e}") |
(to get the traceback)
| return {} | ||
| except Exception as e: | ||
| if self.logger: | ||
| self.logger.error(f"SearXNG API error: {e}") |
Member
There was a problem hiding this comment.
Suggested change
| self.logger.error(f"SearXNG API error: {e}") | |
| self.logger.exception(e, True, f"SearXNG API error: {e}") |
| """Get marketcap API URL""" | ||
| return f"https://data-api.coindesk.com/overview/v1/historical/marketcap/all/assets/days?limit={limit}&response_format=JSON" | ||
|
|
||
| async def _fetch_news_batch(self, session: aiohttp.ClientSession, limit: int = 1000) -> list: |
Member
There was a problem hiding this comment.
I see there is no call to this method (and it's private), I understand it will be used later, right?
Contributor
Author
There was a problem hiding this comment.
Yes, I shouldn't have commit this function, it's used inside my social backtesting branch
Contributor
Author
|
Replaced by Drakkar-Software/OctoBot#3214 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #1693