Repository navigation
feat: Configurable next-up countdown - #1177
Open
MrRussLuther wants to merge 1 commit into
Open
MrRussLuther wants to merge 1 commit into
MrRussLuther wants to merge 1 commit into
Conversation
Adds a "Next-up countdown" slider under the next-up preview setting (5 to 30 seconds, default 30). It sets how long the next-up screen counts down before the next item starts, on both the Flutter player and the native Android player. The "near the end" trigger used by Static, and by Smart when there's no credits segment, now opens the next-up screen countdown + 2 seconds before the end instead of a fixed 32, so a shorter countdown still ends with the video instead of cutting off what's left of it. At the default of 30 it's the same 32 seconds as before. Smart with a credits segment still shows it when the credits start.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Adds a "Next-up countdown" slider under the next-up preview setting (5 to 30 seconds, default 30). It sets how long the next-up screen counts down before the next item starts, on the Flutter player and the native Android player (passed through the pigeon settings).
The "near the end" trigger used by Static, and by Smart when there's no credits segment, now opens the next-up screen countdown + 2 seconds before the end instead of a fixed 32, so a shorter countdown still ends with the video instead of cutting off what's left of it. At the default of 30 that's the same 32 seconds as before. Smart with a credits segment still shows it when the credits start.
Issue Being Fixed
No issue. Related: discussion #978 (autoplay off), this is the other end of that, a shorter wait.
Screenshots / Recordings
The native Android side compiles but I haven't run it on a device.
Tested On
Checklist