Repository navigation
feat: Playback rate presets, step buttons and a desktop input field - #1176
Open
MrRussLuther wants to merge 2 commits into
Open
MrRussLuther wants to merge 2 commits into
MrRussLuther wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The playback rate dialog gets plus and minus buttons that step by 0.05, a row of presets (x0.5, x0.75, x1, x1.25, x1.5, x1.75, x2, matching the native Android picker) and, on desktop, a number field in place of the label so you can type a value. Everything is clamped to the existing 0.25 to 3 range and the slider keeps its 0.05 steps for anyone who wants 1.10 or 1.15. The chips and buttons are focusable, so dPad reaches them. Nothing is persisted, the rate still resets per item like today.
Issue Being Fixed
Discussion #863 asked for the VLC layout (slider, plus and minus, presets) plus a desktop input field.
Screenshots / Recordings
The number field is desktop only, so it isn't in the web capture.
Tested On
Checklist