Improves the operation output views in the Avalonia UI#4743
Merged
Gabriel Dufresne (GabrielDuf) merged 2 commits intoMay 11, 2026
Conversation
Marc-André Moreau (mamoreau-devolutions)
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4681
TextBlockinside anItemsControl, so selection could not span more than one line. Replaced with a singleSelectableTextBlockpopulated with coloredRuninlines (one per line) +LineBreaks, preserving per-line coloring (error / debug / normal) while allowing click-drag selection across the whole log and Ctrl+C copy.OperationOutputWindow) and the failed-operation dialog (OperationFailedDialog) were shown viaShowDialog, which blocked all interaction with the main window. Switched toShow(owner)so the windows remain owned by the main window (stay on top, close with it) but no longer block the rest of the app.Files changed
UniGetUI.Avalonia/Views/DialogPages/OperationOutputWindow.axaml+.axaml.csUniGetUI.Avalonia/Views/DialogPages/OperationFailedDialog.axaml+.axaml.cs(also removed the now-unusedOutputLineVmhelper class)UniGetUI.Avalonia/ViewModels/DialogPages/OperationViewModel.cs(ShowDetailsnow usesShowinstead ofShowDialogfor both branches)