Skip to content

fix: validate filesystem IPC paths#34

Merged
AboMeezO merged 1 commit into
mainfrom
fix/filesystem-ipc-boundaries
Jun 13, 2026
Merged

fix: validate filesystem IPC paths#34
AboMeezO merged 1 commit into
mainfrom
fix/filesystem-ipc-boundaries

Conversation

@AboMeezO

Copy link
Copy Markdown
Member

Summary

  • Validate renderer-provided filesystem and Git IPC paths against registered project roots.
  • Keep Settings access to the app user-data directory working for openPath.

Problem

Several IPC handlers accepted renderer-provided paths directly, allowing a compromised renderer to read, write, open, or run Git operations outside known project directories.

Solution

Add a centralized project-root path validator in the main process and apply it to file read/write, folder watching, recursive directory reads, Git handlers, clone targets, and shell path opening.

Verification

  • npm run typecheck
  • npm run lint
  • npm run build:web

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@AboMeezO, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 14 minutes and 31 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 83552479-9e7e-4aa8-bf4f-a5096bc1c858

📥 Commits

Reviewing files that changed from the base of the PR and between 90f771f and b69d574.

📒 Files selected for processing (1)
  • electron/ipc/handlers.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/filesystem-ipc-boundaries

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AboMeezO AboMeezO merged commit 909e76c into main Jun 13, 2026
2 checks passed
@AboMeezO AboMeezO deleted the fix/filesystem-ipc-boundaries branch June 13, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant