DataGrid: Fix column reordering while using fixed columns (T1316881)#32252
Merged
Alyar666 merged 2 commits intoDevExpress:26_1from Jan 22, 2026
Merged
DataGrid: Fix column reordering while using fixed columns (T1316881)#32252Alyar666 merged 2 commits intoDevExpress:26_1from
Alyar666 merged 2 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in DataGrid column reordering when using fixed columns with virtual column rendering mode (T1316881). The fix removes incorrect column index offset adjustments that were causing reordering to malfunction.
Changes:
- Removed column index offset logic from drag-and-drop column reordering operations
- Updated keyboard navigation to handle column index offset corrections after scrolling
- Refactored column visibility index calculations to handle virtual rendering mode properly
Reviewed changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| m_headers_keyboard_navigation.ts | Added method to correct focused column index after scroll and simplified cell retrieval |
| m_column_keyboard_navigation_core.ts | Removed column index offset adjustments from visibility index calculations |
| m_columns_resizing_reordering.ts | Removed addColumnIndexOffset method and its usage from drag-and-drop operations |
| types.ts | Added type definitions for column index and drop location names |
| m_columns_controller_utils.ts | Refactored getColumnIndexByVisibleIndex to properly handle virtual rendering mode with column offsets |
| const.ts | Added constants for virtual command column and headers location |
| visual.ts | Added visual regression tests for column reordering scenarios |
| functional.ts | Added functional tests for column reordering with fixed columns and virtual rendering |
| columnReordering.ts | Moved existing tests to separate functional.ts and visual.ts files |
e2e/testcafe-devextreme/tests/dataGrid/common/columnReordering/functional.ts
Outdated
Show resolved
Hide resolved
8a6409c to
52a92fc
Compare
...es/devextreme/js/__internal/grids/grid_core/columns_controller/m_columns_controller_utils.ts
Show resolved
Hide resolved
...es/devextreme/js/__internal/grids/grid_core/columns_controller/m_columns_controller_utils.ts
Show resolved
Hide resolved
Raushen
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.