feat: handle web debugger revert event for nextjs - #1176
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for reverting to the original user in the DevCycle debugger by introducing a new message type handler DEVCYCLE_REVERT_TO_ORIGINAL_USER.
- Adds a new message handler for
DEVCYCLE_REVERT_TO_ORIGINAL_USERthat callsidentifyUserwith the original user data - Includes placeholder for Next.js support with a TODO comment
- Imports
useVariableValuein the React test component
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/web-debugger/src/initializeDevCycleDebugger.ts | Adds handler for reverting to original user with identifyUser call and Next.js TODO |
| e2e/react/src/app/DevCycleExample.tsx | Adds unused useVariableValue import to React component |
Comments suppressed due to low confidence (1)
e2e/react/src/app/DevCycleExample.tsx:1
- Unused import useVariableValue.
import { useVariable, useVariableValue } from '@devcycle/react-client-sdk'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a1366c7 to
7db7d77
Compare
7db7d77 to
2d223c8
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| this.client.identifyUser(event.data.user).then(() => { | ||
| this.updateIframeData() | ||
| }) |
There was a problem hiding this comment.
The identifyUser promise lacks error handling. The existing DEVCYCLE_IDENTIFY_USER handler (line 262-264) has the same issue, but both should include a .catch() block to handle potential errors during user identification.
- js-yaml 3.14.1 -> 3.15.0 (medium, alerts #1175, #1176) - js-yaml 4.1.0 -> 4.3.0 (medium, alerts #1171, #1172, #1173, #1174) - webpack-dev-server -> 5.2.5 (medium, alerts #1167, #1168, #1169) - http-proxy-middleware 2.0.9 -> 2.0.10 (medium, alerts #1164, #1165, #1166) - @babel/core -> 7.29.7 (low, alerts #1139, #1140, #1163) - undici -> 6.27.0 (low/medium/high, alerts #1154-#1161) - tar -> 7.5.16 (medium, alerts #1149-#1152) - ws 6.x -> 6.2.4, ws 7.x -> 7.5.11, ws 8.x -> 8.21.0 (high, alerts #1141, #1142, #1145) - form-data 4.0.5 -> 4.0.6 (high, alerts #1143, #1144) - protobufjs -> 7.6.4 (high/medium, alerts #1135, #1136) - protobufjs-cli 1.2.2 -> 1.3.3 (high, alert #1132) - launch-editor -> 2.14.1 (medium, alerts #1134, #1137, #1138) - markdown-it 12.3.2 -> 14.3.0 (medium, alert #1133) - joi 17.6.0 -> 17.13.4 (medium, alert #1125)
Changes