Skip to content

fix: publish flow due to OIDC whoami - #1162

Merged
JamieSinn merged 1 commit into
mainfrom
oidc-publish-fix
Oct 31, 2025
Merged

JamieSinn merged 1 commit into
mainfrom
oidc-publish-fix

Conversation

@JamieSinn

Copy link
Copy Markdown
Member

Overriding the registry also causes issues.

Overriding the registry also causes issues.
@JamieSinn
JamieSinn requested a review from a team as a code owner October 31, 2025 15:41
Copilot AI review requested due to automatic review settings October 31, 2025 15:41
@vercel

vercel Bot commented Oct 31, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
js-sdks-web-elements Ready Ready Preview Comment Oct 31, 2025 3:41pm
js-sdks-with-provider Ready Ready Preview Comment Oct 31, 2025 3:41pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
js-sdks-next-js-page-router Ignored Ignored Oct 31, 2025 3:41pm

@JamieSinn
JamieSinn enabled auto-merge (squash) October 31, 2025 15:41
@JamieSinn JamieSinn changed the title Fix publish flow due to OIDC whoami fix: publish flow due to OIDC whoami Oct 31, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes authentication and registry validation checks from the npm publishing script. The changes simplify the pre-publish validation by eliminating checks that may be redundant or handled elsewhere in the CI/CD pipeline.

Key Changes

  • Removed NPM registry validation that enforced https://registry.yarnpkg.com as the only allowed registry
  • Removed preflight authentication check using npm whoami
  • Eliminated the NPM_REGISTRY variable that was no longer needed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/npm-safe-publish.sh
Comment thread scripts/npm-safe-publish.sh
@JamieSinn
JamieSinn merged commit 7084957 into main Oct 31, 2025
20 of 21 checks passed
@JamieSinn
JamieSinn deleted the oidc-publish-fix branch October 31, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants