Skip to content

fix: Use NPM OIDC - #1150

Merged
JamieSinn merged 5 commits into
mainfrom
use-npm-oidc
Oct 24, 2025
Merged

fix: Use NPM OIDC#1150
JamieSinn merged 5 commits into
mainfrom
use-npm-oidc

Conversation

@JamieSinn

Copy link
Copy Markdown
Member

No description provided.

@JamieSinn
JamieSinn requested a review from a team as a code owner October 15, 2025 14:08
Copilot AI review requested due to automatic review settings October 15, 2025 14:08
@vercel

vercel Bot commented Oct 15, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
js-sdks-web-elements Ready Ready Preview Comment Oct 17, 2025 2:22pm
js-sdks-with-provider Ready Ready Preview Comment Oct 17, 2025 2:22pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
js-sdks-next-js-page-router Ignored Ignored Oct 17, 2025 2:22pm

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Switches publication flow to rely on (implied) npm OIDC by removing manual OTP handling and token secret injection. Key changes simplify the publish script and workflow but also remove explicit authentication validation.

  • Removed OTP argument parsing, auth wrapper function, and auth presence check in npm-safe-publish.sh
  • Replaced npm_authenticated call with direct npm publish
  • Cleared NODE_AUTH_TOKEN secret mapping in release workflow

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
scripts/npm-safe-publish.sh Removes OTP/token handling and publishes directly with npm
.github/workflows/release.yml Removes NODE_AUTH_TOKEN secret mapping (empty secrets_map)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread scripts/npm-safe-publish.sh
Comment thread .github/workflows/release.yml Outdated
@JamieSinn JamieSinn changed the title Use NPM OIDC fix: Use NPM OIDC Oct 17, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread scripts/npm-safe-publish.sh Outdated
Comment thread scripts/npm-safe-publish.sh

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread scripts/npm-safe-publish.sh
Comment thread .github/workflows/release.yml Outdated
Copilot AI review requested due to automatic review settings October 17, 2025 14:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread scripts/npm-safe-publish.sh
JamieSinn and others added 5 commits October 20, 2025 17:00
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings October 20, 2025 21:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JamieSinn
JamieSinn disabled auto-merge October 24, 2025 20:07
@JamieSinn
JamieSinn merged commit 36a777f into main Oct 24, 2025
9 of 12 checks passed
@JamieSinn
JamieSinn deleted the use-npm-oidc branch October 24, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants