fix: setting OpenFeature Provider sdkPlatform, update tests, mark getOpenFeatureProvider() as deprecated - #1113
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes OpenFeature provider integration by properly setting the SDK platform identifier, addressing test instability, and deprecating legacy provider access methods. The changes improve tracking capabilities and guide users toward the recommended DevCycleProvider pattern.
- Set
sdkPlatformto'nodejs-of'for proper OpenFeature integration tracking - Added deprecation warnings to
getOpenFeatureProvider()methods with migration documentation - Fixed test suite by switching to direct DevCycleProvider instantiation and adding proper cleanup
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
sdk/nodejs/src/open-feature/DevCycleProvider.ts |
Sets sdkPlatform to 'nodejs-of' when initializing from SDK key |
sdk/nodejs/src/index.ts |
Adds deprecation warning to getOpenFeatureProvider() method |
sdk/nodejs/src/client.ts |
Adds deprecation warning to getOpenFeatureProvider() method |
sdk/nodejs/__tests__/open-feature-provider/DevCycleProvider.test.ts |
Updates tests to use DevCycleProvider directly and adds proper mock cleanup |
suthar26
approved these changes
Jul 16, 2025
…OpenFeatureProvider() as deprecated
jonathannorris
force-pushed
the
fix-of-provider-sdk-platform
branch
from
July 16, 2025 20:13
3d31d90 to
9bb5802
Compare
jonathannorris
enabled auto-merge (squash)
July 16, 2025 20:17
phaym
pushed a commit
that referenced
this pull request
Jul 16, 2025
…OpenFeatureProvider() as deprecated (#1113)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix OpenFeature Provider SDK Platform and Test Issues
Problem
getOpenFeatureProvider()method lacked clear guidanceChanges
sdkPlatformto'nodejs-of'for proper trackinggetOpenFeatureProvider()methods with migration docsafterEachMigration