-
Notifications
You must be signed in to change notification settings - Fork 5
chore(deps): bump open-feature/go-sdk to v1.17.2 #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5f6c189
chore(deps): bump open-feature/go-sdk to v1.17.2
jonathannorris 1fd6341
refactor: remove dead DevCycleProvider.Status() method
jonathannorris 1ad0f4d
test: assert shutdown via provider.Client rather than internalFullClient
jonathannorris 191a975
chore: re-trigger ci
jonathannorris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this functionality requires a major bump. Just keeping it around and marking deprecated is safer.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had Claude look into this, and I don't think we need to make it a major version, claude's research:
yea it's an exported method so I agree it's technically breaking. Worth noting the history though:
Status()was part of theStateHandlerinterface (Init/Shutdown/Status) up to v1.13.0, and v1.14.0 dropped it. We addedStatus()in #280, which is the same commit that pinned v1.14.1, so it was dead on arrival: no released version of this SDK has shipped a go-sdk that calls it, and it was never documented for direct use.happy to keep it with a
// Deprecated:marker instead if you'd rather play it safe, it's only a few lines. I lean toward removing since it has never done anything, but your call.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather play it safe, just to avoid any potential version incompatibilities if someone didn't update their openfeature SDK to latest, etc.
It's a small chance - but better safe than sorry - especially because we don't know what customers may be using
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea from what I can see this code was never executed because the version of the OF SDK required for using the provider never used this function, I really don't see a point in bumping a major version for that.