Add FreeCleanV2 to enable room cleaning in HA for newer Bots - #1773
Open
MarkusMWolff wants to merge 17 commits into
Open
MarkusMWolff wants to merge 17 commits into
MarkusMWolff wants to merge 17 commits into
Conversation
…nerator parentheses, type hints).
Updated docstring to clarify the type for the clean mode.
Update the XML CleanArea class to accept list[int | float | str] for the area_or_coordinates parameter, matching the JSON CleanArea and CleanAreaV2 signatures. This fixes mypy type errors when passing CleanArea to CapabilityCleanAction, as the Callable signature expects the third parameter to accept these types.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1773 +/- ##
==========================================
- Coverage 96.26% 96.24% -0.03%
==========================================
Files 161 161
Lines 6399 6418 +19
Branches 368 372 +4
==========================================
+ Hits 6160 6177 +17
Misses 172 172
- Partials 67 69 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MarkusMWolff
changed the title
Contributor
Author
|
This should also fix #1749 if their hardware is set to the new command. |
Contributor
Author
|
Hi @edenhaus I would appreciate feedback on this if you find the time to review it 👍 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
after some try and error I found how the freeClean action on newer bots works:
payload=b'{"body":{"data":{"act":"start","content":{"type":"freeClean","value":"1,3"}}},payload=b'{"body":{"data":{"act":"start","content":{"type":"freeClean","value":"1,2;1,3"}}},payload=b'{"body":{"data":{"act":"start","content":{"type":"freeClean","value":"3,null,2414,-226,633,-2038"}}}payload=b'{"body":{"data":{"act":"start","content":{"type":"freeClean","value":"3,null,2434,-414,536,-2129;3,null,-983,-2017,-3097,-3050;1,5"}}}I tried to incorporate these findings as well as possible.
BR, Markus