Feature to format floating point numbers#896
Open
Vanmaele wants to merge 6 commits intoDaveGamble:masterfrom
Open
Feature to format floating point numbers#896Vanmaele wants to merge 6 commits intoDaveGamble:masterfrom
Vanmaele wants to merge 6 commits intoDaveGamble:masterfrom
Conversation
|
The length needs to be adjusted if trailing zeros are removed or else a 0-termination is copied into the output buffer. |
The length needs to be adjusted if trailing zeros are removed or else a 0-termination is copied into the output buffer.
Author
|
Thank you for the review. I've updated it as suggested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work allows to format floating point, either set the decimal point or significant number. If not format preference are given then the driver behaves as before.
Note that JSON specifies to print numbers in it's shortest form, this is still the case e.g. but a number will not be printed longer than e.g. a given decimal point. But a number that has been formatted with a decimal point won't be printed in a scientific notation.