Skip to content

fix: Preserve applied IMPORT hints on importing another .sqrl script#2178

Merged
ferenc-csaky merged 2 commits into
mainfrom
fix/hints-on-imports
Jun 29, 2026
Merged

fix: Preserve applied IMPORT hints on importing another .sqrl script#2178
ferenc-csaky merged 2 commits into
mainfrom
fix/hints-on-imports

Conversation

@ferenc-csaky

Copy link
Copy Markdown
Collaborator

Key Changes

  • Manage inherited imports on planMain
  • Apply inherited imports if there are any when we create PlannerHints during SQRL script planning
  • Added DAG planner test case to cover the inherit logic

Fixes #2102

@ferenc-csaky ferenc-csaky requested review from mateczagany and velo June 29, 2026 13:03
@ferenc-csaky ferenc-csaky added this to the 0.10.7 milestone Jun 29, 2026
@ferenc-csaky ferenc-csaky added the bug Something isn't working label Jun 29, 2026
@ferenc-csaky ferenc-csaky removed this from the 0.10.7 milestone Jun 29, 2026
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.44%. Comparing base (2e44441) to head (5463c19).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...n/java/com/datasqrl/planner/hint/PlannerHints.java 0.00% 7 Missing ⚠️
...in/java/com/datasqrl/planner/SqlScriptPlanner.java 0.00% 6 Missing ⚠️
.../java/com/datasqrl/compile/CompilationProcess.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2178      +/-   ##
============================================
- Coverage     15.44%   15.44%   -0.01%     
  Complexity      975      975              
============================================
  Files           618      618              
  Lines         17832    17837       +5     
  Branches       2176     2177       +1     
============================================
  Hits           2755     2755              
- Misses        14807    14812       +5     
  Partials        270      270              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@ferenc-csaky ferenc-csaky enabled auto-merge (squash) June 29, 2026 15:33
@ferenc-csaky ferenc-csaky requested a review from mateczagany June 29, 2026 15:33
@ferenc-csaky ferenc-csaky merged commit 71145de into main Jun 29, 2026
16 checks passed
@ferenc-csaky ferenc-csaky deleted the fix/hints-on-imports branch June 29, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hints on IMPORT (ttl, no_query, insert) are silently ignored instead of applied or rejected

2 participants