feat: Add rate limiter for Kafka sources#357
Merged
Merged
Conversation
|
|
||
| public class RateLimitOptions { | ||
|
|
||
| public static final ConfigOption<Double> SCAN_RATE_LIMIT_RECORDS_PER_SECOND = |
Collaborator
There was a problem hiding this comment.
I think we can use Integer for the config property, i don't think it's realistic that anybody will give a fractional number, it's only double cause it will be divided by the parallelism, cause this is applied per-subtask.
Collaborator
Author
There was a problem hiding this comment.
Good idea, thank you!
ferenc-csaky
pushed a commit
that referenced
this pull request
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional Kafka source emission rate limiting via
scan.rate-limit.records-per-second.It's being implemented by using a wrapper that preserves Kafka checkpoint/restart behavior by delegating method calls to the underlying Kafka source. The limiter throttles emitted records, not Kafka fetches. If Kafka fetches ahead, un-emitted records are not checkpointed as consumed and will be refetched after restart.
CountingSourceOutputis used becauseSourceReader.pollNext()only returnsInputStatus, not an emitted-record count. This keeps limiting based on actualcollect()calls while avoiding Flink 2.2.1’s built-inRateLimitedSourceReader, which does not delegate checkpoint-complete callbacks to the actual input source.