Repository navigation
Load the dd-openfeature SDK of the same build for java dev - #8196
cbeauchesne wants to merge 2 commits into
Conversation
Java dev only loaded the dd-java-agent snapshot, so weblogs and the parametric app used the latest released dd-openfeature from Maven. Since dd-trace-java#12844, a dev agent does not work with a released SDK, and the parametric FFE tests fail with PROVIDER_NOT_READY. dd-trace-java publishes dd-openfeature.jar next to dd-java-agent.jar: load it too, and keep the released one if it's missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4361c32037
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Falling back to the released SDK hid every download failure, not only a missing jar, and the released SDK does not work with a dev agent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
replaced by #8188 |
Motivation
Since dd-trace-java#12844 (merged 2026-10-26), the Java dev parametric FFE tests fail with
PROVIDER_NOT_READY(48 tests inparametric (2)), e.g. on #8186:load-binary.shonly loads thedd-java-agent.jarsnapshot, so weblogs and the parametric app use the latest releaseddd-openfeaturefrom Maven ([1.56.0,))Last green run: tracer
90f57b50ca; first red one:e7584c7bca, which includes #12844.Changes
For
javadev,load-binary.shalso downloadsdd-openfeature.jarfrom the same S3 folder asdd-java-agent.jar. dd-trace-java uploads both in the same CI job, so they come from the same build. The weblog and parametric install scripts already pick up add-openfeature*.jarfrombinaries/.java_lambda: its runtime image has no Maven to install the jar, and its weblog doesn't use the SDK--retry 3), and any failure failsload-binary.sh: falling back to the released SDK would hide the problem behind misleading FFE failures. A dd-trace-java branch whose last pipeline predates #12844 (which added the upload) has nodd-openfeature.jar: a new pipeline on it publishes onespring-boot-3-nativeignores the jar: its GraalVM image has nofind, soinstall_ddtrace.shsees no custom jar and keeps the released SDK, which this weblog doesn't use anywayTested locally:
javaonmasterloads both jars (dd-openfeature1.69.0-SNAPSHOT), a missing SDK jar fails the script (exit 22), andjava_lambdaonly loads the agent.🤖 Generated with Claude Code