-
Notifications
You must be signed in to change notification settings - Fork 166
test(profiling): add function name length tests #3571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Claude Opus 4.5 <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3571 +/- ##
==========================================
- Coverage 62.02% 61.92% -0.11%
==========================================
Files 140 140
Lines 13309 13309
Branches 1762 1762
==========================================
- Hits 8255 8241 -14
- Misses 4265 4278 +13
- Partials 789 790 +1 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ profiler ]Benchmark execution time: 2026-01-16 19:11:05 Comparing candidate commit 63decfd in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 27 metrics, 8 unstable metrics. scenario:php-profiler-timeline-memory-with-profiler-and-timeline
|
b85dd09 to
1315a9f
Compare
1315a9f to
63decfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I added a commit to make a zend_string_alloc equivalent helper and then nudge it closer to what the engine really does. Please check it out before merging. Rest looks good to me! We're hitting the rate limit but these were passing before, I can't see how I messed them up.
#2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/datadog/dd-appsec-php-ci/manifests/sha256:15a9e23372df35fbb9c587ef7d3ec69be4b134be9742e108a70999f081e75e53: 429 Too Many Requests - Server message: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit
Description
Re-adds the tests that got removed in #3570 and fixes the linking problem. You may review commit by commit.
Reviewer checklist