Skip to content

Conversation

@realFlowControl
Copy link
Member

Description

Re-adds the tests that got removed in #3570 and fixes the linking problem. You may review commit by commit.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@realFlowControl realFlowControl requested a review from a team as a code owner January 13, 2026 09:29
@datadog-official
Copy link

datadog-official bot commented Jan 13, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 2 New flaky tests detected

testUserLoginFailureEvent from symfony-44-test.DDTrace\Tests\Integrations\Symfony\V4_4\AutomatedLoginEventsTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Symfony\V4_4\AutomatedLoginEventsTest::testUserLoginFailureEvent
Failed asserting that 0 matches expected 1.

tests/Integrations/Symfony/AutomatedLoginEventsTestSuite.php:74
tests/Common/RetryTraitVersionGeneric.php:28
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testUserLoginSuccessEvent from symfony-44-test.DDTrace\Tests\Integrations\Symfony\V4_4\AutomatedLoginEventsTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Symfony\V4_4\AutomatedLoginEventsTest::testUserLoginSuccessEvent
Failed asserting that 0 matches expected 1.

tests/Integrations/Symfony/AutomatedLoginEventsTestSuite.php:56
tests/Common/RetryTraitVersionGeneric.php:28
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106

🧪 1022 Tests failed

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 696a9a2600000000a5bfa0272bf7c0e8
tid: 696a9a2600000000
hexProcessTraceId: a5bfa0272bf7c0e8
hexProcessSpanId: b27edf06bd49af9f
processTraceId: 11943440826911670504
processSpanId: 12861962805855235999

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
View all
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 63decfd | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@github-actions github-actions bot added profiling Relates to the Continuous Profiler tracing labels Jan 13, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.92%. Comparing base (ed3089e) to head (63decfd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3571      +/-   ##
==========================================
- Coverage   62.02%   61.92%   -0.11%     
==========================================
  Files         140      140              
  Lines       13309    13309              
  Branches     1762     1762              
==========================================
- Hits         8255     8241      -14     
- Misses       4265     4278      +13     
- Partials      789      790       +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed3089e...63decfd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Jan 14, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-01-16 19:11:05

Comparing candidate commit 63decfd in PR branch florian/function-name-length-tests with baseline commit ed3089e in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 27 metrics, 8 unstable metrics.

scenario:php-profiler-timeline-memory-with-profiler-and-timeline

  • 🟥 execution_time [+25.323ms; +38.159ms] or [+2.057%; +3.100%]

@morrisonlevi morrisonlevi force-pushed the florian/function-name-length-tests branch from b85dd09 to 1315a9f Compare January 16, 2026 18:50
@morrisonlevi morrisonlevi force-pushed the florian/function-name-length-tests branch from 1315a9f to 63decfd Compare January 16, 2026 18:55
Copy link
Collaborator

@morrisonlevi morrisonlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I added a commit to make a zend_string_alloc equivalent helper and then nudge it closer to what the engine really does. Please check it out before merging. Rest looks good to me! We're hitting the rate limit but these were passing before, I can't see how I messed them up.

#2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/datadog/dd-appsec-php-ci/manifests/sha256:15a9e23372df35fbb9c587ef7d3ec69be4b134be9742e108a70999f081e75e53: 429 Too Many Requests - Server message: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Relates to the Continuous Profiler tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants