Repository navigation
Conversation
Debugger tests built CoreTracers with the default agent writer and never closed them. Each one kept a serializer thread alive, pinning that writer's 5 MB payload buffer, so the test JVM accumulated them until agent-debugger:test ran out of its 512 MB heap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (370.086 µs) : 331, 410
. : milestone, 370,
basic (343.305 µs) : 337, 349
. : milestone, 343,
loop (8.116 ms) : 8052, 8180
. : milestone, 8116,
section candidate
noprobe (370.746 µs) : 348, 393
. : milestone, 371,
basic (345.424 µs) : 338, 353
. : milestone, 345,
loop (8.123 ms) : 8060, 8187
. : milestone, 8123,
|
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Debugger tests now close the
CoreTracers they build.Motivation
:dd-java-agent:agent-debugger:testruns out of its 512 MB heap on master.PayloadDispatcherImplinstances retained 225 MB, 65% of the heap, about 5.2 MB each.TraceProcessingWorkerserializer threads.CoreTracer.builder().build(), which uses the default agent writer, and never close the tracer. The writer's thread stays alive and pins its msgpack buffer, created on the first trace written.ExceptionProbeInstrumentationTestbuilds one per test in@BeforeEach, and Add coordinated sampling for snapshot probes #12452 addedCoordinatedSamplingTestwith nine more call sites.The fix:
CapturingTestBasesubclasses, that's a shared field, closed inCapturingTestBase.after().LogProbeTestbuilds several per test, so it closes them in a list@AfterEach.The test task now completes: 950 tests, 15 skipped, no failures, no OOM.
Additional Notes
Test-only change.
🤖 Generated with Claude Code