[dougqh]

What Does This Do

Adds two values to Metadata, the per-span object serializers receive:

• getGlobalTags(): the trace's global tags (DD_TAGS, or their remote-config override, which keeps the configured env and version);
• getSpanDefaultTags(): the trace's span defaults (DD_TRACE_SPAN_TAGS plus tracer-defined tags such as env), without the global tags. While a remote-config override is active, only the tracer-defined tags.

DDSpanContext fills both from the trace's config snapshot (TraceCollector.getTraceConfig()), using the maps #12937 added. Every span in a trace shares its collector's snapshot, so a config change mid-trace can't split one trace across two sets of global tags.

getTags() is unchanged and still includes both. Serializers that don't care about tag levels need no changes.

Motivation

This gets #12813 (OTLP) what it needs to write DD_TAGS once on the Resource instead of on every span, without reaching into TagMap internals or comparing values against the static Config:

• Span attributes: the span's direct tags, plus getSpanDefaultTags() minus the keys the span sets itself;
• Resource: getGlobalTags().

The encoder change itself stays with #12813.

The accessors are named for what the tags are, not where they come from. If trace-level state later moves to its own object (a trace segment), only DDSpanContext changes and serializers don't notice.

Additional Notes

• Builds on Keep global tags apart from span defaults in the config snapshot (OTLP trace/resource-level split) #12937 and Add test for remote config tracing tags overriding DD_TAGS (OTLP trace/resource-level split) #12936, both merged. Rebased onto master, so the diff is only this PR's change.
• Cost: two more references on each Metadata (one per serialized span, on the serializer thread) and one field read from the trace's snapshot. No change on the application thread.
• Tests:
  • new CoreTracerTest.metadataCarriesTheTraceConfigTagLevels: a span started before a config change still serializes its trace's original maps (same instances);
  • existing Metadata constructor call sites in tests pass TagMap.EMPTY;
  • PayloadDispatcherImplTest builds a real DDSpanContext on a mocked PendingTrace whose default answer returned a null snapshot. It now returns a real one. In production the snapshot is never null: PendingTrace and StreamingTraceCollector fall back to captureTraceConfig().
• Local runs:
  • dd-trace-core: the only failures are two Docker-based tests (no Docker locally) and two known timing tests (DDAgentWriterCombinedTest, PendingTraceBufferTest). Both timing tests pass when run on their own.
  • dd-trace-ot passes, and the traceAgentTest and jmh source sets compile.

🤖 Generated with Claude Code

[dd-octo-sts]

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	14.74 s	14.49 s	[+0.7%; +2.7%] (maybe worse)
startup:insecure-bank:tracing:Agent	13.51 s	13.62 s	[-1.6%; -0.0%] (maybe better)
startup:petclinic:appsec:Agent	17.71 s	17.60 s	[-0.3%; +1.5%] (no difference)
startup:petclinic:iast:Agent	17.50 s	17.64 s	[-1.5%; -0.0%] (maybe better)
startup:petclinic:profiling:Agent	17.28 s	16.87 s	[-2.3%; +7.2%] (no difference)
startup:petclinic:sca:Agent	17.65 s	17.55 s	[-0.2%; +1.5%] (no difference)
startup:petclinic:tracing:Agent	16.55 s	16.71 s	[-2.1%; +0.2%] (no difference)

Commit: 017f6e62 · CI Pipeline · Benchmarking Platform UI

---

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

[mcculls]

The changes here make sense, building on the separation in the earlier PR

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-22T20:20:35.909108Z	709a142	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[datadog-official]

More details

The tag-level separation preserves span-default precedence, and serializers receive the trace collector’s captured maps, keeping each trace consistent across configuration changes.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit 709a142}

[dd-octo-sts]

/merge

[gh-worker-devflow-routing-ef8351]

View all feedbacks in Devflow UI.

2026-10-23 03:18:57 UTC ℹ️ Start processing command /merge

---

2026-10-23 03:19:01 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

---

2026-10-23 04:14:51 UTC ℹ️ MergeQueue: This merge request was merged