-
Notifications
You must be signed in to change notification settings - Fork 324
WIP #10393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jandro996
wants to merge
5
commits into
master
Choose a base branch
from
alejandro.gonzalez/add-apm-trace-metrics-tags
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP #10393
+1,327
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~18e580b1e0, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086006
Total [baseline] (8.779 s) : 0, 8779019
Agent [candidate] (1.088 s) : 0, 1088234
Total [candidate] (8.778 s) : 0, 8778348
section iast
Agent [baseline] (1.234 s) : 0, 1233720
Total [baseline] (9.358 s) : 0, 9357544
Agent [candidate] (1.232 s) : 0, 1231547
Total [candidate] (9.344 s) : 0, 9343520
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~18e580b1e0, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (652.139 ms) : 0, 652139
BytebuddyAgent [candidate] (653.636 ms) : 0, 653636
GlobalTracer [baseline] (283.294 ms) : 0, 283294
GlobalTracer [candidate] (284.029 ms) : 0, 284029
AppSec [baseline] (32.608 ms) : 0, 32608
AppSec [candidate] (32.849 ms) : 0, 32849
Debugger [baseline] (67.715 ms) : 0, 67715
Debugger [candidate] (67.443 ms) : 0, 67443
Remote Config [baseline] (621.755 µs) : 0, 622
Remote Config [candidate] (668.252 µs) : 0, 668
Telemetry [baseline] (8.991 ms) : 0, 8991
Telemetry [candidate] (8.975 ms) : 0, 8975
Flare Poller [baseline] (3.814 ms) : 0, 3814
Flare Poller [candidate] (3.848 ms) : 0, 3848
section iast
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (798.528 ms) : 0, 798528
BytebuddyAgent [candidate] (797.654 ms) : 0, 797654
GlobalTracer [baseline] (258.986 ms) : 0, 258986
GlobalTracer [candidate] (257.108 ms) : 0, 257108
IAST [baseline] (27.373 ms) : 0, 27373
IAST [candidate] (27.054 ms) : 0, 27054
AppSec [baseline] (35.316 ms) : 0, 35316
AppSec [candidate] (34.548 ms) : 0, 34548
Debugger [baseline] (63.956 ms) : 0, 63956
Debugger [candidate] (65.588 ms) : 0, 65588
Remote Config [baseline] (584.059 µs) : 0, 584
Remote Config [candidate] (589.785 µs) : 0, 590
Telemetry [baseline] (8.536 ms) : 0, 8536
Telemetry [candidate] (8.495 ms) : 0, 8495
Flare Poller [baseline] (3.588 ms) : 0, 3588
Flare Poller [candidate] (3.646 ms) : 0, 3646
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~18e580b1e0, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1093956
Total [baseline] (10.812 s) : 0, 10811852
Agent [candidate] (1.088 s) : 0, 1087585
Total [candidate] (10.924 s) : 0, 10924138
section appsec
Agent [baseline] (1.267 s) : 0, 1267386
Total [baseline] (11.078 s) : 0, 11078043
Agent [candidate] (1.269 s) : 0, 1269414
Total [candidate] (11.038 s) : 0, 11038131
section iast
Agent [baseline] (1.227 s) : 0, 1227194
Total [baseline] (11.198 s) : 0, 11198037
Agent [candidate] (1.236 s) : 0, 1235795
Total [candidate] (11.138 s) : 0, 11137875
section profiling
Agent [baseline] (1.206 s) : 0, 1205665
Total [baseline] (11.024 s) : 0, 11024103
Agent [candidate] (1.209 s) : 0, 1208569
Total [candidate] (10.922 s) : 0, 10922102
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~18e580b1e0, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (657.201 ms) : 0, 657201
BytebuddyAgent [candidate] (653.195 ms) : 0, 653195
GlobalTracer [baseline] (285.023 ms) : 0, 285023
GlobalTracer [candidate] (283.421 ms) : 0, 283421
AppSec [baseline] (32.92 ms) : 0, 32920
AppSec [candidate] (32.542 ms) : 0, 32542
Debugger [baseline] (68.381 ms) : 0, 68381
Debugger [candidate] (68.28 ms) : 0, 68280
Remote Config [baseline] (632.226 µs) : 0, 632
Remote Config [candidate] (616.88 µs) : 0, 617
Telemetry [baseline] (8.964 ms) : 0, 8964
Telemetry [candidate] (8.943 ms) : 0, 8943
Flare Poller [baseline] (3.798 ms) : 0, 3798
Flare Poller [candidate] (3.77 ms) : 0, 3770
section appsec
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (692.393 ms) : 0, 692393
BytebuddyAgent [candidate] (693.856 ms) : 0, 693856
GlobalTracer [baseline] (259.628 ms) : 0, 259628
GlobalTracer [candidate] (259.534 ms) : 0, 259534
IAST [baseline] (24.516 ms) : 0, 24516
IAST [candidate] (24.556 ms) : 0, 24556
AppSec [baseline] (172.771 ms) : 0, 172771
AppSec [candidate] (174.056 ms) : 0, 174056
Debugger [baseline] (67.485 ms) : 0, 67485
Debugger [candidate] (66.938 ms) : 0, 66938
Remote Config [baseline] (760.642 µs) : 0, 761
Remote Config [candidate] (731.369 µs) : 0, 731
Telemetry [baseline] (9.421 ms) : 0, 9421
Telemetry [candidate] (9.291 ms) : 0, 9291
Flare Poller [baseline] (3.818 ms) : 0, 3818
Flare Poller [candidate] (3.69 ms) : 0, 3690
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (793.347 ms) : 0, 793347
BytebuddyAgent [candidate] (800.526 ms) : 0, 800526
GlobalTracer [baseline] (257.11 ms) : 0, 257110
GlobalTracer [candidate] (258.089 ms) : 0, 258089
IAST [baseline] (26.974 ms) : 0, 26974
IAST [candidate] (27.102 ms) : 0, 27102
AppSec [baseline] (34.729 ms) : 0, 34729
AppSec [candidate] (35.216 ms) : 0, 35216
Debugger [baseline] (65.566 ms) : 0, 65566
Debugger [candidate] (65.218 ms) : 0, 65218
Remote Config [baseline] (573.808 µs) : 0, 574
Remote Config [candidate] (610.812 µs) : 0, 611
Telemetry [baseline] (8.5 ms) : 0, 8500
Telemetry [candidate] (8.579 ms) : 0, 8579
Flare Poller [baseline] (3.617 ms) : 0, 3617
Flare Poller [candidate] (3.537 ms) : 0, 3537
section profiling
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (701.947 ms) : 0, 701947
BytebuddyAgent [candidate] (703.876 ms) : 0, 703876
GlobalTracer [baseline] (221.078 ms) : 0, 221078
GlobalTracer [candidate] (221.739 ms) : 0, 221739
AppSec [baseline] (32.198 ms) : 0, 32198
AppSec [candidate] (32.134 ms) : 0, 32134
Debugger [baseline] (68.139 ms) : 0, 68139
Debugger [candidate] (68.758 ms) : 0, 68758
Remote Config [baseline] (636.006 µs) : 0, 636
Remote Config [candidate] (640.984 µs) : 0, 641
Telemetry [baseline] (8.904 ms) : 0, 8904
Telemetry [candidate] (8.925 ms) : 0, 8925
Flare Poller [baseline] (3.707 ms) : 0, 3707
Flare Poller [candidate] (3.789 ms) : 0, 3789
ProfilingAgent [baseline] (97.949 ms) : 0, 97949
ProfilingAgent [candidate] (97.223 ms) : 0, 97223
Profiling [baseline] (98.543 ms) : 0, 98543
Profiling [candidate] (97.8 ms) : 0, 97800
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 14 metrics, 21 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~18e580b1e0, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section baseline
no_agent (1.185 ms) : 1173, 1196
. : milestone, 1185,
iast (3.128 ms) : 3091, 3166
. : milestone, 3128,
iast_FULL (5.67 ms) : 5614, 5726
. : milestone, 5670,
iast_GLOBAL (3.437 ms) : 3384, 3490
. : milestone, 3437,
profiling (2.05 ms) : 2032, 2069
. : milestone, 2050,
tracing (1.808 ms) : 1794, 1823
. : milestone, 1808,
section candidate
no_agent (1.175 ms) : 1163, 1187
. : milestone, 1175,
iast (3.158 ms) : 3116, 3200
. : milestone, 3158,
iast_FULL (5.908 ms) : 5848, 5968
. : milestone, 5908,
iast_GLOBAL (3.658 ms) : 3599, 3717
. : milestone, 3658,
profiling (2.273 ms) : 2252, 2294
. : milestone, 2273,
tracing (1.836 ms) : 1820, 1851
. : milestone, 1836,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~18e580b1e0, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section baseline
no_agent (18.126 ms) : 17939, 18312
. : milestone, 18126,
appsec (18.874 ms) : 18682, 19066
. : milestone, 18874,
code_origins (17.799 ms) : 17620, 17978
. : milestone, 17799,
iast (17.692 ms) : 17517, 17866
. : milestone, 17692,
profiling (18.763 ms) : 18579, 18947
. : milestone, 18763,
tracing (18.221 ms) : 18038, 18403
. : milestone, 18221,
section candidate
no_agent (19.235 ms) : 19038, 19431
. : milestone, 19235,
appsec (18.553 ms) : 18366, 18740
. : milestone, 18553,
code_origins (17.483 ms) : 17314, 17653
. : milestone, 17483,
iast (17.66 ms) : 17485, 17836
. : milestone, 17660,
profiling (18.762 ms) : 18573, 18952
. : milestone, 18762,
tracing (17.745 ms) : 17567, 17923
. : milestone, 17745,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~18e580b1e0, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.457 ms) : 2404, 2511
. : milestone, 2457,
iast (2.219 ms) : 2152, 2286
. : milestone, 2219,
iast_GLOBAL (2.263 ms) : 2196, 2330
. : milestone, 2263,
profiling (2.082 ms) : 2028, 2136
. : milestone, 2082,
tracing (2.051 ms) : 1998, 2103
. : milestone, 2051,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.456 ms) : 2403, 2509
. : milestone, 2456,
iast (2.224 ms) : 2158, 2291
. : milestone, 2224,
iast_GLOBAL (2.269 ms) : 2201, 2336
. : milestone, 2269,
profiling (2.489 ms) : 2327, 2651
. : milestone, 2489,
tracing (2.055 ms) : 2002, 2108
. : milestone, 2055,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~18e580b1e0, baseline=1.59.0-SNAPSHOT~a08b93afcb
dateFormat X
axisFormat %s
section baseline
no_agent (15.586 s) : 15586000, 15586000
. : milestone, 15586000,
appsec (14.868 s) : 14868000, 14868000
. : milestone, 14868000,
iast (18.388 s) : 18388000, 18388000
. : milestone, 18388000,
iast_GLOBAL (17.999 s) : 17999000, 17999000
. : milestone, 17999000,
profiling (14.942 s) : 14942000, 14942000
. : milestone, 14942000,
tracing (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
section candidate
no_agent (15.655 s) : 15655000, 15655000
. : milestone, 15655000,
appsec (15.066 s) : 15066000, 15066000
. : milestone, 15066000,
iast (18.475 s) : 18475000, 18475000
. : milestone, 18475000,
iast_GLOBAL (17.937 s) : 17937000, 17937000
. : milestone, 17937000,
profiling (15.536 s) : 15536000, 15536000
. : milestone, 15536000,
tracing (14.74 s) : 14740000, 14740000
. : milestone, 14740000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm waf
Application Security Management (WAF)
tag: do not merge
Do not merge changes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]