[chouquette]

What does this PR do?

Sets the rpm payload compression in dd_pkg_rpm to xz: level 9 when //:is_release is set and level 5 otherwise. Packages can no longer override it.
Also enable multi threaded compression.

Motivation

The omnibus rpms are xz-compressed (they require rpmlib(PayloadIsXz)), unlike the Bazel ones. The package parity check (#58991) reports the difference.
The levels mirror omnibus, using the release flag as the replacement for its deploy detection.

This PR is stacked on the release opt-in PR (#59217), so that regular builds default to level 5.

Describe how you validated your changes

Built a small rpm through dd_pkg_rpm: xz level 5 by default and level 9 with --config=release. Both require rpmlib(PayloadIsXz).

Additional notes

bazelbuild/rules_pkg#1094 is related so that we can avoid overcommiting on resources.
In our case, since packaging are usually the last actions, we shouldn't notice much difference though.

[datadog-datadog-us1-prod]

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 66.83% (+0.00%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: cca69e1 | Docs | Give us feedback!}

[dd-octo-sts]

Static quality checks

❌ Please find below the results from static quality gates
Comparison made with ancestor 61f86b5
📊 Static Quality Gates Dashboard
🔗 SQG Job

Error

	Quality gate	Change	Size (prev → curr → max)
❌	docker_host_profiler_amd64 (on disk)	+26.46 KiB (0.01% increase, -138.42% of buffer)	314.681 → 314.707 → 314.700
❌	docker_host_profiler_arm64 (on disk)	+26.47 KiB (0.01% increase, -106.38% of buffer)	325.476 → 325.502 → 325.500

Gate failure full details

Quality gate	Error type	Error message
docker_host_profiler_amd64	AbsoluteLimitExceeded	static_quality_gate_docker_host_profiler_amd64 failed! Disk size 314.7 MB exceeds limit of 314.7 MB by 7.3 KB
docker_host_profiler_arm64	AbsoluteLimitExceeded	static_quality_gate_docker_host_profiler_arm64 failed! Disk size 325.5 MB exceeds limit of 325.5 MB by 1.6 KB

Static quality gate failures prevent this PR from merging!
You can check the static quality gates runbooks page for guidance and tools. Please either fix the size violation or request an exception.

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	docker_agent_amd64	+3.51 KiB (0.00% increase, -0.07% of buffer)	817.472 → 817.476 → 822.670
✅	docker_agent_arm64	+3.58 KiB (0.00% increase, -0.06% of buffer)	811.481 → 811.484 → 817.260
✅	docker_agent_jmx_amd64	+3.53 KiB (0.00% increase, -0.07% of buffer)	1008.336 → 1008.340 → 1013.540
✅	docker_agent_jmx_arm64	+3.6 KiB (0.00% increase, -0.06% of buffer)	991.128 → 991.132 → 996.910

27 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	761.466 MiB
✅	agent_deb_amd64_fips	692.115 MiB
✅	agent_heroku_amd64	313.727 MiB
✅	agent_msi	669.784 MiB
✅	agent_rpm_amd64	761.449 MiB
✅	agent_rpm_amd64_fips	692.097 MiB
✅	agent_rpm_arm64	730.799 MiB
✅	agent_rpm_arm64_fips	667.213 MiB
✅	agent_suse_amd64	761.449 MiB
✅	agent_suse_amd64_fips	692.097 MiB
✅	agent_suse_arm64	730.799 MiB
✅	agent_suse_arm64_fips	667.213 MiB
✅	docker_cws_instrumentation_amd64	7.513 MiB
✅	docker_cws_instrumentation_arm64	7.002 MiB
✅	docker_dogstatsd_amd64	40.228 MiB
✅	docker_dogstatsd_arm64	38.255 MiB
✅	dogstatsd_deb_amd64	30.976 MiB
✅	dogstatsd_deb_arm64	28.898 MiB
✅	dogstatsd_rpm_amd64	30.976 MiB
✅	dogstatsd_suse_amd64	30.976 MiB
✅	iot_agent_deb_amd64	48.284 MiB
✅	iot_agent_deb_arm64	44.661 MiB
✅	iot_agent_deb_armhf	45.475 MiB
✅	iot_agent_rpm_amd64	48.284 MiB
✅	iot_agent_suse_amd64	48.283 MiB
✅	docker_cluster_agent_amd64	217.811 MiB
✅	docker_cluster_agent_arm64	230.526 MiB

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: 43b09bd0-3898-4c65-8cbc-8efe085df15e

Baseline: 77b05af
Comparison: 3821261
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_metrics_logs	memory utilization	+0.81	[+0.59, +1.04]	1	Logs bounds checks dashboard
➖	dsd_uds_10mb_3k_timestamped_contexts_memory	memory utilization	+0.29	[+0.07, +0.51]	1	Logs
➖	python_openmetrics	% cpu utilization	+0.23	[-0.44, +0.90]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	+0.23	[+0.19, +0.27]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	+0.15	[+0.12, +0.19]	1	Logs bounds checks dashboard
➖	dsd_uds_client_drop_detector_cpu	% cpu utilization	+0.08	[-0.46, +0.62]	1	Logs
➖	quality_gate_security_no_fs_load	memory utilization	+0.02	[-0.04, +0.08]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	-0.02	[-0.06, +0.02]	1	Logs bounds checks dashboard
➖	quality_gate_private_action_runner	memory utilization	-0.23	[-0.35, -0.11]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.40	[-0.47, -0.32]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-1.77	[-2.68, -0.86]	1	Logs bounds checks dashboard
➖	dsd_uds_10mb_3k_timestamped_contexts_cpu	% cpu utilization	-2.14	[-2.39, -1.89]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	python_openmetrics	checks_execution_time	10/10	82.57 ≤ 100	bounds checks dashboard
✅	python_openmetrics	cpu_usage	10/10	1364.62 ≤ 1500	bounds checks dashboard
✅	python_openmetrics	memory_usage	10/10	4.31GiB ≤ 4.75GiB	bounds checks dashboard
✅	quality_gate_idle	intake_connections	10/10	4 ≤ 5	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	185.52MiB ≤ 188MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	779.94KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	2 ≤ 5	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	474.56MiB ≤ 542MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.17MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	20 ≤ 40	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	223.60MiB ≤ 232MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.35MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	365.44 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	20 ≤ 40	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	416.00MiB ≤ 461MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.95GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_private_action_runner	memory_usage	10/10	76.02MiB ≤ 78MiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	31.91 ≤ 100	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	336.05MiB ≤ 363MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	43.46 ≤ 200	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	316.75MiB ≤ 341MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	26.25 ≤ 100	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	343.57MiB ≤ 354MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.