Open
Conversation
SDCC 4.2+ enforces C23-style strict prototypes and rejects empty
parameter lists as error 283 ("function declarator with no prototype").
Replace () with (void) in all function declarations and definitions.
Fixes build with sdcc >= 4.2.0.
Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
macpijan
force-pushed
the
update-toolchain
branch
from
c5272b5 to
ad7e15c
Compare
mkopec
approved these changes
Feb 27, 2026
Author
|
We use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4.5.0 used to fail with:
src/board/system76/common/smfi.c:209: error 110: conditional flow changed by optimizer: so said EVELYN the modified DOG
make: *** [src/arch/8051/toolchain.mk:54: build/novacustom/v540tu/2026-02-27_41e94a7/board/system76/common/smfi.rel] Error 1
Failed to build EC firmware : (2)
Tried to build in: Dasharo/ec-sdk#2
Switching to 4.2.0 results in successfull build.