[TFN Port] Sawn-Off Addition#1202
Conversation
|
You currently have a negative Fix/Feature pull request delta of -50. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
chazzyjazzy
left a comment
chazzyjazzy
left a comment
There was a problem hiding this comment.
i notice that in this port, lever action, shotgun, and double barrel are all can_be_sawn_off
but in the tfn pr, musket and ak74 are also can_be_sawn_off
|
|
||
| /obj/item/gun/ballistic/automatic/darkpack/ak74/sawn | ||
| name = "sawn-off Kalashnikov's Automatic Rifle 74" | ||
| desc = "Pretty old, but also easy fireable and cleanable by vodka. This one has had its stock removed and the barrel chopped; it's a miracle it still cycles! Uses 5.45 rounds." |
There was a problem hiding this comment.
unsure of about how accurate the rest of the values are but atleast for stuff like desc, the current process for sawning off a gun does not inherit said value. I honestly wonder if sawing off a gun should just have a set subtpye it "turns into" and then just desc = sawnoff_subtype::desc, repeating for other important values. that way its more consistant with mapped subtypes.
There was a problem hiding this comment.
looks like there is a var, sawn_desc? i see what youre saying tho, these items are a bit different than the /tg/ sawoff() in ballistic.dm (not to mention sawoff() directs to specific icon paths and states
3 participants
About The Pull Request
Adds in more sawn off gun varients. Specifically:
See full additions on: The-Final-Nights/The-Final-Nights-Rebase#373
Also, there's videos that can be provided of testing. Works well, feels decently balanced due to firearm recoil changes.
Why It's Good For The Game
Flavor, concealable firearm variants that is somewhat TT friendly, and feels decently balanced.
Changelog
🆑
add: Adds new sawn off variants of the AK, pump-shotgun, lever action, and musket.
/:cl: