Pierced Viel works and some signal cleanup#1195
Open
FalloutFalcon wants to merge 3 commits into
Open
Conversation
chazzyjazzy
approved these changes
Jul 5, 2026
Contributor
|
Error: /datum/splat/werewolf/shifter/proc/revert_to_breed_form sets SpacemanDMM_should_not_sleep but calls blocking proc /proc/tgui_input_list |
chazzyjazzy
requested changes
Jul 8, 2026
chazzyjazzy
left a comment
Contributor
There was a problem hiding this comment.
just slapping a changes req cuz linters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Was looking through this downstreams commit enzosousa1@d845cd3
Its AI but I did realize some mistakes in my or others code reading through it so i replicated a few of its changes or fixed some others.
Main thing is I had a var on the species and a proc on the splat that had the same name and i got them mixed up.
Why It's Good For The Game
bad code is bad.
Changelog
🆑
code: cleans up some random signal stuff
fix: Pierced Veil should work as intended for delerium effects
/:cl: