Skip to content

Pierced Viel works and some signal cleanup#1195

Open
FalloutFalcon wants to merge 3 commits into
DarkPack13:masterfrom
FalloutFalcon:code-cleanup
Open

Pierced Viel works and some signal cleanup#1195
FalloutFalcon wants to merge 3 commits into
DarkPack13:masterfrom
FalloutFalcon:code-cleanup

Conversation

@FalloutFalcon

@FalloutFalcon FalloutFalcon commented Jul 5, 2026

Copy link
Copy Markdown
Member

About The Pull Request

Was looking through this downstreams commit enzosousa1@d845cd3
Its AI but I did realize some mistakes in my or others code reading through it so i replicated a few of its changes or fixed some others.

Main thing is I had a var on the species and a proc on the splat that had the same name and i got them mixed up.

Why It's Good For The Game

bad code is bad.

Changelog

🆑
code: cleans up some random signal stuff
fix: Pierced Veil should work as intended for delerium effects
/:cl:

@chazzyjazzy

Copy link
Copy Markdown
Contributor

Error: /datum/splat/werewolf/shifter/proc/revert_to_breed_form sets SpacemanDMM_should_not_sleep but calls blocking proc /proc/tgui_input_list
Error: /datum/splat/werewolf/shifter/proc/revert_to_breed_form sets SpacemanDMM_should_not_sleep but calls blocking proc /proc/stoplag
Error: /datum/splat/werewolf/shifter/proc/revert_to_breed_form sets SpacemanDMM_should_not_sleep but calls blocking proc /datum/tgui_window/proc/initialize
Error: Process completed with exit code 1.

@chazzyjazzy chazzyjazzy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just slapping a changes req cuz linters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants