Removed deprecated sn fcls#205
Open
emanuele-villa wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Removes two deprecated supernova MARLEY FHiCL configs that were accidentally left behind after a restructuring and would now be broken/unused.
Changes:
- Delete
prodmarley_nue_flat_es_dune10kt_1x2x2.fcl - Delete
prodmarley_nue_flat_cc_dune10kt_1x2x2.fcl
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| fcl/dunefd/gen/supernova/prodmarley_nue_flat_es_dune10kt_1x2x2.fcl | Removed deprecated ES 1x2x2 MARLEY configuration. |
| fcl/dunefd/gen/supernova/prodmarley_nue_flat_cc_dune10kt_1x2x2.fcl | Removed deprecated CC 1x2x2 MARLEY configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These ended up there because of a PR going in after the restructuring. They shall not be used, they would result to be broken now.