Open
Conversation
alexbooth92
reviewed
Apr 10, 2026
Member
|
Grat work @giacomo-santoni! I've left a comment above which I think needs to be addressed before we can move forward. |
jacoblarkin
reviewed
Apr 13, 2026
jacoblarkin
reviewed
Apr 13, 2026
jacoblarkin
requested changes
Apr 13, 2026
Co-authored-by: Jacob Larkin <larkin.jacob@gmail.com>
alexbooth92
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
run-sandrecostep to ND_Production workflow:1.
run-sandrecostep implementationrun_sandreco.shfor SAND reconstruction2. Configuration management
fast_reco_v0.template.jsonconfig_json.pyscript for dynamic parameterization of config filesMoreover,
pull_singularity_container.shhas been modified in order to be more easily customisable. The existing options are kept as defaults.