Improved the naming of configuration session name and DAQ session name variables used in integtests#153
Merged
bieryAtFnal merged 4 commits intodevelopfrom Apr 16, 2026
Conversation
added 4 commits
March 8, 2026 12:26
… as config_session_name and renamed session_name as daq_session_name to help make their meaning more clear.
…ession_name_changes
…ession_name_changes
… we pass to Popen in a local variable so that we don't have it typed in twice (thus reducing the chance of the two instances getting out of sync).
This was referenced Apr 15, 2026
eflumerf
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes are intended to be included in
fddaq-v5.7.0...To me, it seems really beneficial to improve the naming of variables and parameters in our code so that we can differentiate between Configuration Session names (aka OKS Session names) and DAQ Session names.
One of the places in our existing code where I found the current names confusing is in the
integrationtestdrunc_configdata structure.To help make things more clear, I propose that we modify
drunc_config.sessiontodrunc_config.config_session_namedrunc_config.session_nametodrunc_config.daq_session_nameThis PR has these changes. If there are suggestions for better new names, we can certainly talk about that (
configuration_session_name?).These changes are coupled with ones in the following repositories:
Here are suggested instructions for testing the full set of changes:
I have run tests on
daq.fnal.govandnp04-srv-029with all of the modified integtests (dunedaq_integtest_bundle.sh -r local), and the results look good.And, I should say that I have additional improvements planned to help make it easier for users to know how to specify configuration (
confgen_parameters) information in our integtests.Type of change
Testing checklist
dunedaq_integtest_bundle.sh)