Revise DFO protocol to enhance resilience and consensus by Copilot · Pull Request #486 · DUNE-DAQ/dfmodules

Copilot · 2026-04-15T12:58:23Z

Create include/dfmodules/DFODecision.hpp
Extend src/dfmodules/DFOCore.hpp and src/DFOCore.cpp
Rewrite plugins/DFOConsensusModule.hpp and .cpp
Update test/config/dfo_consensus_test.data.xml
Update unittest/DFOConsensusModule_test.cxx
Fix atomic snapshot races and clarifying comments
Fix WatchdogFailover test: start watchdog unconditionally in do_start so peers announcing after do_start are covered

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/a3b1396a-ba81-4d0d-9afe-944cee92d6ee Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

eflumerf · 2026-04-16T16:21:50Z

@copilot The new module should only inherit from DAQModule. Common DFO code can be moved to library functions in either src or plugins/detail

…helper Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/ed628aeb-4879-45d9-b86a-d95d7f541e66 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/ed628aeb-4879-45d9-b86a-d95d7f541e66 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot · 2026-04-16T16:46:26Z

@copilot The new module should only inherit from DAQModule. Common DFO code can be moved to library functions in either src or plugins/detail

Done in commit b280c75. DFOConsensusModule now inherits DAQModule directly, with no dependency on DFOModule. All common DFO processing logic (TRB management, slot selection, dispatching, token handling, busy notification, opmon counters) has been extracted into src/dfmodules/DFOCore.hpp/.cpp and added to the library. Both DFOModule and DFOConsensusModule use DFOCore via unique_ptr composition.

eflumerf · 2026-04-16T18:29:22Z

@copilot Add unit tests for DFOCore

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/a1889c64-61e1-42b6-9525-fb129d8e5168 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot · 2026-04-16T18:38:08Z

@copilot Add unit tests for DFOCore

Done in commit 812721a. Added unittest/DFOCore_test.cxx with 12 test cases covering: copy/move semantics, constructor state, configure/start/stop/scrap lifecycle, TRB registration (new_trb_fn callback), TRB reconnect, run-number mismatch handling in tokens and TDs, successful TD dispatch with opmon counters, stop() returning in-flight TDs as remnants, and round-robin/fallback slot selection.

…hang Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/29005214-4521-4327-be2c-9d0620eec67b Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

…ule_test Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/2ce026ec-732c-4c57-99eb-f2bd16f5db6b Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

…s complete before remove_callback

…-protocol-resilience

…g failover Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/8cfa3196-9570-48f5-a552-ad88bae3d298 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

…comments, watchdog logs) Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/8cfa3196-9570-48f5-a552-ad88bae3d298 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

…ments are handled Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/ad5ee7fa-bbd5-49fc-8323-82e234ed90b9 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Initial plan

ed8ee63

Copilot AI assigned Copilot and eflumerf Apr 15, 2026

Copilot started work on behalf of eflumerf April 15, 2026 12:58 View session

Copilot AI linked an issue Apr 15, 2026 that may be closed by this pull request

Make the DFO Protocol resilient #428

Open

Copilot finished work on behalf of eflumerf April 15, 2026 14:44

eflumerf closed this Apr 15, 2026

eflumerf removed a link to an issue Apr 15, 2026

Make the DFO Protocol resilient #428

Open

eflumerf reopened this Apr 15, 2026

Copilot started work on behalf of eflumerf April 15, 2026 14:48 View session

Copilot stopped work on behalf of eflumerf due to an error April 15, 2026 15:01
Job was cancelled

Copilot started work on behalf of eflumerf April 15, 2026 15:02 View session

Implement DFO consensus algorithm with deterministic partitioning

d9d2192

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/a3b1396a-ba81-4d0d-9afe-944cee92d6ee Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot finished work on behalf of eflumerf April 15, 2026 15:27

Copilot AI requested a review from eflumerf April 15, 2026 15:27

Copilot started work on behalf of eflumerf April 16, 2026 16:21 View session

Copilot AI and others added 2 commits April 16, 2026 16:43

Refactor: DFOConsensusModule inherits DAQModule directly via DFOCore …

2f51404

…helper Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/ed628aeb-4879-45d9-b86a-d95d7f541e66 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

style: use named copy + std::move for peer announcement sends

b280c75

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/ed628aeb-4879-45d9-b86a-d95d7f541e66 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Revise DFO protocol to enhance resilience and consensus~~ Revise DFO protocol to enhance resilience and consensus Apr 16, 2026

Copilot finished work on behalf of eflumerf April 16, 2026 16:47

Move source file to src directory

f28114c

Copilot started work on behalf of eflumerf April 16, 2026 18:29 View session

test: add DFOCore unit tests (12 test cases)

812721a

Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/a1889c64-61e1-42b6-9525-fb129d8e5168 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot finished work on behalf of eflumerf April 16, 2026 18:39

Copilot started work on behalf of eflumerf April 16, 2026 20:45 View session

fix: register triginh callback in CfgFixture to prevent DFOCore test …

0c800c1

…hang Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/29005214-4521-4327-be2c-9d0620eec67b Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot finished work on behalf of eflumerf April 16, 2026 20:49

Copilot started work on behalf of eflumerf April 16, 2026 21:11 View session

fix: add missing triginh callback to SendTrigDecFailed test in DFOMod…

f5e22e6

…ule_test Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/2ce026ec-732c-4c57-99eb-f2bd16f5db6b Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot finished work on behalf of eflumerf April 16, 2026 21:15

eflumerf added 2 commits April 20, 2026 08:40

Separate stop and flush so that any pending trigger decision callback…

a1e7656

…s complete before remove_callback

Merge remote-tracking branch 'origin/develop' into copilot/revise-dfo…

dde446a

…-protocol-resilience

Copilot started work on behalf of eflumerf April 20, 2026 14:17 View session

Copilot finished work on behalf of eflumerf April 20, 2026 14:20

Copilot started work on behalf of eflumerf April 20, 2026 14:24 View session

Copilot AI and others added 2 commits April 20, 2026 14:48

feat: DFODecision broadcast, remote-slot shadow, global busy, watchdo…

c719937

…g failover Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/8cfa3196-9570-48f5-a552-ad88bae3d298 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

fix: address code review comments (atomic snapshot races, clarifying …

aaaee1d

…comments, watchdog logs) Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/8cfa3196-9570-48f5-a552-ad88bae3d298 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot finished work on behalf of eflumerf April 20, 2026 14:53

Copilot started work on behalf of eflumerf April 20, 2026 16:34 View session

fix: start watchdog unconditionally in do_start so late peer announce…

b9d855c

…ments are handled Agent-Logs-Url: https://github.com/DUNE-DAQ/dfmodules/sessions/ad5ee7fa-bbd5-49fc-8323-82e234ed90b9 Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>

Copilot finished work on behalf of eflumerf April 20, 2026 16:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revise DFO protocol to enhance resilience and consensus#486

Revise DFO protocol to enhance resilience and consensus#486
Copilot wants to merge 13 commits intodevelopfrom
copilot/revise-dfo-protocol-resilience

Copilot AI commented Apr 15, 2026 •

edited

Loading

Uh oh!

eflumerf commented Apr 16, 2026

Uh oh!

Copilot AI commented Apr 16, 2026

Uh oh!

eflumerf commented Apr 16, 2026

Uh oh!

Copilot AI commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eflumerf commented Apr 16, 2026

Uh oh!

Copilot AI commented Apr 16, 2026

Uh oh!

eflumerf commented Apr 16, 2026

Uh oh!

Copilot AI commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Apr 15, 2026 •

edited

Loading