[9.1] Add DiracX support into the database.#8196
Open
Robin-Van-de-Merghel wants to merge 1 commit intoDIRACGrid:integrationfrom
Open
[9.1] Add DiracX support into the database.#8196Robin-Van-de-Merghel wants to merge 1 commit intoDIRACGrid:integrationfrom
Robin-Van-de-Merghel wants to merge 1 commit intoDIRACGrid:integrationfrom
Conversation
chrisburr
reviewed
May 16, 2025
Robin-Van-de-Merghel
force-pushed
the
robin-add-diracx-pilotdb
branch
6 times, most recently
from
e5e6870 to
e4c3e28
Compare
Robin-Van-de-Merghel
force-pushed
the
robin-add-diracx-pilotdb
branch
from
e4c3e28 to
3bb6ac8
Compare
Contributor
Author
Robin-Van-de-Merghel
force-pushed
the
robin-add-diracx-pilotdb
branch
from
c62bd16 to
70d6ea4
Compare
Robin-Van-de-Merghel
force-pushed
the
robin-add-diracx-pilotdb
branch
from
70d6ea4 to
5f54d5a
Compare
Robin-Van-de-Merghel
changed the title
chrisburr
reviewed
Aug 5, 2025
| `AccountingSent` ENUM('True','False') NOT NULL DEFAULT 'False', | ||
| PRIMARY KEY (`PilotID`), | ||
| KEY `PilotJobReference` (`PilotJobReference`), | ||
| KEY `PilotStamp` (`PilotStamp`), |
Contributor
Author
There was a problem hiding this comment.
Can't be unique in DIRAC:
- DIRAC creates a pilot with a reference
- CEs generate stamps and returns to DIRAC
- DIRAC associates these stamps with pilots
Contributor
Author
There was a problem hiding this comment.
To be refactored in DiracX as stamps are the primary indentifier
chrisburr
reviewed
Aug 5, 2025
Robin-Van-de-Merghel
force-pushed
the
robin-add-diracx-pilotdb
branch
from
5f54d5a to
3a12e74
Compare
Contributor
Author
|
Is this PR useful? It only adds a key for pilot stamps I mean, as we move the secret table into DiracX auth, normally the database is automatically created without the need to implement it in DIRAC? POC: https://github.com/DIRACGrid/DIRAC/actions/runs/16797372818/job/47570725488?pr=8279 working without adding the DB in DIRAC. |
Contributor
|
I also doubt it is needed. |
Contributor
Author
|
Maybe just keep the Key for performance improvment ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
*WMS
FIX: Add future DiracX Pilots DB (support for secrets)
ENDRELEASENOTES