Skip to content

Added a edit icon to top right of edited image#869

Open
savukadoo wants to merge 2 commits intoCyberTimon:mainfrom
savukadoo:feature/add-edited-icon-to-image
Open

Added a edit icon to top right of edited image#869
savukadoo wants to merge 2 commits intoCyberTimon:mainfrom
savukadoo:feature/add-edited-icon-to-image

Conversation

@savukadoo
Copy link
Copy Markdown

Description

This PR adds a Pencil icon to edited images in the filmstrip and Library section of RapidRAW. This is helpful in identifying what images have been edited vs what images have not been images.

Type of Change

  • [ x] New feature

Changes Made

  • Added a Pencil icon to the Library section to any images that have been edited
  • Added a Pencil icon to the Filmstrip section for any images that have been edited

Screenshots/Videos

Screenshot 2026-03-14 at 22 07 16 Screenshot 2026-03-14 at 22 07 29

Testing

  • [ x] I have tested these changes locally and confirmed that they work as expected without issues

Test Configuration:

  • OS: macOS Tahoe
  • Hardware: Apple M2

Checklist

  • [ x] My code follows the project's code style
  • [ x] I haven't added unnecessary AI-generated code comments
  • [ x] My changes generate no new warnings or errors

Additional Notes

AI Disclaimer:

Please state the involvement of AI in this PR:

  • [ x] This PR contains only blood, sweat, and coffee (AI-free)

@CyberTimon
Copy link
Copy Markdown
Owner

Hi @savukadoo

I will take a look soon, but I have a quick question.

Does it update correctly or does it become stale when you for example reset adjustments (it's in unedited state then). This was the reason #203 isn't merged yet.

Thanks!

@savukadoo
Copy link
Copy Markdown
Author

Il do some testing and confirm whether this occurs. Just to be clear so I understand the behavior we want.

  • When a image is edited we want a icon to show that its been adjusted
  • When a user selects the image and selects reset adjustments we want the edit icon to be removed
  • What do we want to happen when a user rates and image or tags an image or color labels an image?
  • Where do we want the edit icon to show, on the left top corner or the right top hand corner ?

Thanks

@SimonIT
Copy link
Copy Markdown
Contributor

SimonIT commented Mar 16, 2026

Amd what if the user manually resets a slider? (For example drags it to 0 or double click and no other slider was changed)

@CyberTimon
Copy link
Copy Markdown
Owner

The main issue here is that an 'edited' state is actually pretty tricky to define. A sidecar file gets created even if you just rate or tag an image, but we only want the icon to show up for actual visual changes.

Also, if a user tweaks a slider and then moves it right back to the default value, the icon should ideally disappear. Keeping that state perfectly synced across the the editor and during batch actions (like pasting settings) is where most attempts at this end up feeling buggy or stale. We need to make sure the indicator is always telling the truth.

@danschef
Copy link
Copy Markdown

danschef commented Mar 20, 2026

Just an idea without knowing how the adjustments are actually stored in the sidecar files:

What about storing a boolean value in the sidecar file that contains the "edited" state and which is refreshed every time the sidecar file is touched - lets say by simply computing the sum of all absolute edits (I guess they are stored somehow numerically). If it is zero, then set edited=False or even remove the sidecar file entirely.

@SimonIT
Copy link
Copy Markdown
Contributor

SimonIT commented Mar 20, 2026

We could compare a static fresh rrdata struct with the actual one of the picture. If they are not equal, it is edited. This of course must be done on every change of any slider etc. This could happen in a function is_default(). I don't know the actual structure of the data. In case of multiple structs you could even create a trait for it.

@CyberTimon
Copy link
Copy Markdown
Owner

On my phone rn, but an ideal place for this would be the save function. This way we don‘t have to compare on every slider tick.

@savukadoo
Copy link
Copy Markdown
Author

savukadoo commented Mar 21, 2026

I think I have finally got to a point that has a potential working solution and I have done some testing on my side that looks like its the behavior we want , however I would need some more testing on your side to confirm that it is working as you expect it too.

Changes:

  1. Moving a slider away from any of the default (0) value shows the pencil icon.
  2. Returning the slider to default (0) value removes the pencil icon immediately.
  3. Resetting adjustments removes the pencil icon.
  4. Reopening an unedited image should keep the pencil icon hidden
  5. Moved the pencil icon to the right and aligned it with the star rating if that is added.
Screen.Recording.2026-03-21.at.18.52.09.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants