Added a edit icon to top right of edited image#869
Added a edit icon to top right of edited image#869savukadoo wants to merge 2 commits intoCyberTimon:mainfrom
Conversation
|
Hi @savukadoo I will take a look soon, but I have a quick question. Does it update correctly or does it become stale when you for example reset adjustments (it's in unedited state then). This was the reason #203 isn't merged yet. Thanks! |
|
Il do some testing and confirm whether this occurs. Just to be clear so I understand the behavior we want.
Thanks |
|
Amd what if the user manually resets a slider? (For example drags it to 0 or double click and no other slider was changed) |
|
The main issue here is that an 'edited' state is actually pretty tricky to define. A sidecar file gets created even if you just rate or tag an image, but we only want the icon to show up for actual visual changes. Also, if a user tweaks a slider and then moves it right back to the default value, the icon should ideally disappear. Keeping that state perfectly synced across the the editor and during batch actions (like pasting settings) is where most attempts at this end up feeling buggy or stale. We need to make sure the indicator is always telling the truth. |
|
Just an idea without knowing how the adjustments are actually stored in the sidecar files: What about storing a boolean value in the sidecar file that contains the "edited" state and which is refreshed every time the sidecar file is touched - lets say by simply computing the sum of all absolute edits (I guess they are stored somehow numerically). If it is zero, then set |
|
We could compare a static fresh rrdata struct with the actual one of the picture. If they are not equal, it is edited. This of course must be done on every change of any slider etc. This could happen in a function |
|
On my phone rn, but an ideal place for this would be the save function. This way we don‘t have to compare on every slider tick. |
|
I think I have finally got to a point that has a potential working solution and I have done some testing on my side that looks like its the behavior we want , however I would need some more testing on your side to confirm that it is working as you expect it too. Changes:
Screen.Recording.2026-03-21.at.18.52.09.webm |
Description
This PR adds a Pencil icon to edited images in the filmstrip and Library section of RapidRAW. This is helpful in identifying what images have been edited vs what images have not been images.
Type of Change
Changes Made
Screenshots/Videos
Testing
Test Configuration:
Checklist
Additional Notes
AI Disclaimer:
Please state the involvement of AI in this PR: