Add the abilty to set a connection timeout separate from socket timeout#71
Open
jaiew wants to merge 1 commit intoCyberSource:masterfrom
Open
Add the abilty to set a connection timeout separate from socket timeout#71jaiew wants to merge 1 commit intoCyberSource:masterfrom
jaiew wants to merge 1 commit intoCyberSource:masterfrom
Conversation
Author
|
Just wondering if there has been a chance to look at this? |
hc0503
approved these changes
Nov 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the connection timeout to be configured differently from the socket timeout.
Getting a connection should be relatively quick and you don't want to tie that to the same timeout as waiting for a request to process.
This makes the retry functionality much better as well as it only retries on connection failures.