Fix and update D3DDevice_CopyRects signatures#224
Merged
Conversation
github-actions
Bot
added
OOVPA
PatrickvL
approved these changes
Aug 2, 2025
PatrickvL
left a comment
PatrickvL
left a comment
Member
There was a problem hiding this comment.
Only did a visual inspection, but looks good. Just one lint issue to resolve.
Member
Author
|
Lint issue is currently a bug as it should be checking against diffs which isn't working at this time. Please disregard it until macros for wip future support for D3D's member variables are fully integrated. As they are the cause of issue. |
ergo720
reviewed
Aug 2, 2025
RadWolfie
force-pushed
the
d3d-oovpa-fixes
branch
from
August 2, 2025 18:00
5add94e to
3f611ce
Compare
Removed: - 4034 (d3d8) - 1036 (4627, d3d8ltcg) - 1048 (4928, d3d8ltcg) - 1024 (5455, d3d8ltcg) Updated: - 3911 (d3d8) - 4627 (d3d8) - 5120 (d3d8) Added: - 3911 (d3d8ltcg) - 4627 (d3d8ltcg) - 5121 (d3d8ltcg)
Added: - 4628 (4627, 2nd revision for special case)
RadWolfie
force-pushed
the
d3d-oovpa-fixes
branch
from
August 2, 2025 18:02
3f611ce to
c7d5527
Compare
Member
Author
|
I noticed 1036 (d3d8ltcg) signature was not removed, so I went ahead delete it as part of fixup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original bug was from the Project: Snowblind title received the wrong detected address for D3DDevice_CopyRects. Since the signatures are very old, I went ahead majority replaced them with the new signatures. With these new updated signatures, even more titles are able to detect D3DDevice_CopyRects symbol.
The first commit made these LTCG titles able to detect the symbol:
Then the second commit was brought to my attention relative to the change of order of having allocated stack 2 assembly instructions later, instead of at the beginning. These titles are also LTCG:
Titles with existing symbol detected did not show a change of address or loss of detected symbol.
resolve #222 ticket