Skip to content

fix(storage): compact authenticated construction detail records - #1176

Merged
DecisionNerd merged 2 commits into
mainfrom
fix/1172-compact-construction-details
Sep 9, 2026
Merged

fix(storage): compact authenticated construction detail records#1176
DecisionNerd merged 2 commits into
mainfrom
fix/1172-compact-construction-details

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Private construction detail runs reserve 255 bytes for each label or route, even for short names. Store the exact UTF-8 name bytes in new version-7 sessions while preserving every UUID and continuing genuine version-6 sessions with their original fixed codec. Authentication, merge, recovery, and canonical encoding use the session-bound codec and count actual wire bytes and decoded rows. A genuine version-6 crash before initial checkpoint installation recovers its codec from a complete, matching initial temporary; unknown, conflicting, or changed authority is rejected without promoting temporary contents.

An equal-input 1,024-node/1,024-edge fixture crosses multiple merge levels and resumes before shape, after shape, and after publication. Detail EOF drops from 589,824 to 74,752 bytes; measured construction peak drops from 2,170,880 to 1,134,592 bytes. Exact allocation and reference inventories include zero-byte files, with persistent lifecycle/writer locks initialized before the fixture baseline. This establishes a representation reduction; #901/#900/#745 retain host-capacity qualification.

Validation includes codec boundaries and malformed input, both-version crash/cancel/corruption/retry, 89 affected storage tests, exact public construction/reopen/portable verification/import results including nullable properties and ordinals, and full lifecycle 1x/2x/4x phase accounting. The existing application-byte fixture uses proportionally more rows to exceed its unchanged fixed-overhead floor; phase ceilings remain enforced. The tiny construction test now derives its exact fsync count and tighter merge footprint bound from compact wire sizes, replacing legacy padded-size assumptions. Workspace Clippy, final formatting, make pre-push-fast, and gate-registry checks pass. Exact-head Bazel CI also runs the real default tiny lifecycle and full-owner 1x/2x/4x growth workload before merge.

Closes #1172

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 7e7f49f0-bab2-4897-a824-143c53cacbdc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added core Core source code changes documentation Improvements or additions to documentation labels Sep 9, 2026
@blacksmith-sh

This comment has been minimized.

@DecisionNerd
DecisionNerd merged commit 3868e3c into main Sep 9, 2026
23 checks passed
@DecisionNerd
DecisionNerd deleted the fix/1172-compact-construction-details branch September 9, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core source code changes documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(storage): compact authenticated construction detail records

2 participants