fix(scale): account for complete lifecycle storage ownership - #1167
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The lifecycle certifier omitted live construction/import files and transaction controls, so storage qualification rejected otherwise correct scale runs. This change tracks actual writer allocation through an explicit per-command diagnostic context and reports raw facts for all 15 retained owner views. Every command's reported current allocation must match a fresh physical inventory; the peak comes from observed writes and removals.
The new
/2lifecycle receipt and current profiles move together, with historical/1evidence still readable. Normal facade options stay unchanged. Failure, cancellation, and retry cleanup preserve real allocation evidence and the original error.Validation on the actual public SCALE1 lifecycle passed all ten phases, including clean import and reopen/query proof. Reported retained allocation of 983,040 bytes exactly matched an independent device/inode-deduplicated filesystem measurement; observed peak was 1,040,384 bytes. The regression checks all five raw facts for live construction, import, and transaction owners. The native consumer also accepted the actual lifecycle receipt, both storage snapshots, and committed application I/O.
Targeted tests cover aliases, atomic replacement, recovery errors and retries, export and materializer cleanup, dropped async result exports, bounded private input, and closed receipt validation. Workspace Clippy with warnings denied, repository fast checks, and both workspace formatting checks passed.
Canonical S20/S22 ladder qualification remains tracked in #951.
Closes #1165
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.