Skip to content

fix(scale): account for complete lifecycle storage ownership - #1167

Merged
DecisionNerd merged 2 commits into
mainfrom
fix/1165-private-storage-ownership
Sep 9, 2026
Merged

fix(scale): account for complete lifecycle storage ownership#1167
DecisionNerd merged 2 commits into
mainfrom
fix/1165-private-storage-ownership

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

The lifecycle certifier omitted live construction/import files and transaction controls, so storage qualification rejected otherwise correct scale runs. This change tracks actual writer allocation through an explicit per-command diagnostic context and reports raw facts for all 15 retained owner views. Every command's reported current allocation must match a fresh physical inventory; the peak comes from observed writes and removals.

The new /2 lifecycle receipt and current profiles move together, with historical /1 evidence still readable. Normal facade options stay unchanged. Failure, cancellation, and retry cleanup preserve real allocation evidence and the original error.

Validation on the actual public SCALE1 lifecycle passed all ten phases, including clean import and reopen/query proof. Reported retained allocation of 983,040 bytes exactly matched an independent device/inode-deduplicated filesystem measurement; observed peak was 1,040,384 bytes. The regression checks all five raw facts for live construction, import, and transaction owners. The native consumer also accepted the actual lifecycle receipt, both storage snapshots, and committed application I/O.

Targeted tests cover aliases, atomic replacement, recovery errors and retries, export and materializer cleanup, dropped async result exports, bounded private input, and closed receipt validation. Workspace Clippy with warnings denied, repository fast checks, and both workspace formatting checks passed.

Canonical S20/S22 ladder qualification remains tracked in #951.

Closes #1165


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 4fbe313b-b30b-49e6-9091-408a83af5631

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added core Core source code changes testing Test coverage and testing infrastructure documentation Improvements or additions to documentation labels Sep 9, 2026
@github-actions github-actions Bot added the tooling Developer tooling and automation label Sep 9, 2026
@DecisionNerd
DecisionNerd merged commit f6da8d0 into main Sep 9, 2026
23 checks passed
@DecisionNerd
DecisionNerd deleted the fix/1165-private-storage-ownership branch September 9, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core source code changes documentation Improvements or additions to documentation testing Test coverage and testing infrastructure tooling Developer tooling and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(scale): include live private storage in lifecycle allocation ownership

2 participants