refactor(exec): own path hydration and query resources - #1154
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Path-node hydration previously performed storage reads inside
graphforge-rel, outside execution-owned memory and cancellation controls. Move hydration into exec with retained authenticated providers, the query's memory pool, fallible reservations, and whole-query cancellation. Recursive expression binding preserves nested quantifier/list-comprehension evaluation and propagates resource errors.Shared Arrow schemas now live in IR with storage compatibility reexports. Rel has no production storage dependency in Cargo or Bazel, and the unused
StorageProviderstubs are removed. This completes the remaining boundary work after #1148.Validation:
The write cancellation regression proves owner drop before paused collection resumes; it does not claim interruption of an actively running synchronous callback. Output lifetime/RSS metering and new backend support are not introduced. The independently reproduced main-branch fixed-hop SET/path-return defect is tracked in #1153.
Closes #1006
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.