Skip to content

refactor(exec): own path hydration and query resources - #1154

Merged
DecisionNerd merged 3 commits into
mainfrom
refactor/1006-exec-path-hydration
Sep 7, 2026
Merged

refactor(exec): own path hydration and query resources#1154
DecisionNerd merged 3 commits into
mainfrom
refactor/1006-exec-path-hydration

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Path-node hydration previously performed storage reads inside graphforge-rel, outside execution-owned memory and cancellation controls. Move hydration into exec with retained authenticated providers, the query's memory pool, fallible reservations, and whole-query cancellation. Recursive expression binding preserves nested quantifier/list-comprehension evaluation and propagates resource errors.

Shared Arrow schemas now live in IR with storage compatibility reexports. Rel has no production storage dependency in Cargo or Bazel, and the unused StorageProvider stubs are removed. This completes the remaining boundary work after #1148.

Validation:

  • Facade unit tests: 703 passed; API BDD: 118 passed; full TCK: 3,897 passed, zero regressions.
  • Hydration: 11 passed, including actual pool refusal/release, nested error propagation, selected recovery-health refusal, sibling partitions, public write prefix/suffix owner drop, and retained rows across sixteen stems.
  • Read/write integration: 8 + 21 passed; relational units/goldens: 232 + 15 passed.
  • Workspace Clippy, fast gate, gate registry, formatting and Cargo/Bazel drift passed.
  • Final rebase onto merged parser work: locked rel/exec/API check and hydration 11 + read 8 + write 21 rerun passed; full workspace and benchmark locked metadata passed. The benchmark lock change removes only rel’s former production storage edge.

The write cancellation regression proves owner drop before paused collection resumes; it does not claim interruption of an actively running synchronous callback. Output lifetime/RSS metering and new backend support are not introduced. The independently reproduced main-branch fixed-hop SET/path-return defect is tracked in #1153.

Closes #1006


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: f4e2d466-d8d4-4350-ae1b-edc441eb299b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added planner Changes to query planner executor Changes to query executor core Core source code changes documentation Improvements or additions to documentation labels Sep 7, 2026
@DecisionNerd
DecisionNerd merged commit d81acda into main Sep 7, 2026
23 checks passed
@DecisionNerd
DecisionNerd deleted the refactor/1006-exec-path-hydration branch September 7, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core source code changes documentation Improvements or additions to documentation executor Changes to query executor planner Changes to query planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(rel): eliminate runtime storage I/O from the lowering stage

2 participants