Open
Conversation
…izing YAML from disk.
|
Hi @Crell , are you planning on ever implementing this feature? Seems very promising. #[ClassNameTypeMap(key: 'type')]
public readonly ?TypeField $typeField;This allows Serde to use the correct TypeField when deserializing |
Owner
Author
|
Yeah, I still want to do this. It's just never been a high enough priority for me to get to. (And I have a kid now. 😄 ) If you want to send a new PR or a PR against this one, I can try to have a look at some point. Though it likely needs a rebase, too... As I said, I'm not sure the code here is the right way to do it, but it confirms that it can be done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP at the moment. The goal is to get to the point where we can write a class analyzer (from AttributeUtils) that, instead of parsing with reflection, will read from a YAML file that has been hand-crafted. But we also want the ability to write out a template of said file from the class/attributes.
The goal is to allow things like defining the ORM settings or serializer settings entirely in YAML, without having to put attributes into the class. (Also doing JSON or array would be trivial at that point, but YAML is the most popular target.)
I'm now reasonably confident that this will work, but not on the particular way I have it working. I'm putting this PR up in case anyone else wants to weigh in before I next find time to play with it.
Feedback welcome at this point.