Add stickyHeader setting to fix graph header while scrolling - #1
Draft
plitzenberger wants to merge 2 commits into
Draft
Add stickyHeader setting to fix graph header while scrolling#1plitzenberger wants to merge 2 commits into
plitzenberger wants to merge 2 commits into
Conversation
Introduce git-graph.stickyHeader (default true) so the control bar and column headers stay visible when scrolling the Graph View, following the approach from upstream PR mhutchie#394. Co-authored-by: Philipp Litzenberger <philipp@bendcircular.com>
Restrict web/tsconfig types to node and include es2016.array.include so tsc no longer pulls in incompatible babel declaration files. Co-authored-by: Philipp Litzenberger <philipp@bendcircular.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new extension setting
git-graph.stickyHeader(defaulttrue) that keeps the Graph View control bar and column headers fixed at the top while scrolling.This implements the long-requested sticky header behavior (upstream #132 / #394):
package.json,Config,GitGraphViewConfig, and the webview initial state#controlsand#tableColHeadersuseposition: stickyDisable with:
Test plan
Config.stickyHeaderconfig.test,gitGraphView.test— 439 tests)npm run compilesucceeds"git-graph.stickyHeader": falserestores previous scroll-away behavior