feat(configurations): migrate ConfigurationCard and ConfigurationsIndex to CnCard and CnIndexPage#936
Open
SudoThijn wants to merge 7 commits intofeature/REGISTERS-481/entities-pagefrom
Conversation
…IndexPage components Refactors ConfigurationCard.vue to use CnCard and CnStatusBadge from @conduction/nextcloud-vue, replacing the bespoke card markup. All status badges (Local, External, Discovered, sync status, update available, published) are converted to CnStatusBadge with icon slots and solid variants. The actions menu moves into the #actions slot, metadata footer into the #footer slot, and a syncBadgeVariant computed property drives badge colour based on sync status. Refactors ConfigurationsIndex.vue to use CnIndexPage, replacing the hand-rolled header, actions bar, view-mode switcher, card grid, and full table implementation. Card view uses a #card slot with ConfigurationCard; table columns use #column-* slots for title, source type, status badges, and version. The Import Configuration button is surfaced via the #action-items slot. Removes leftover debug logging and simplifies isRemoteConfiguration to a one-liner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigurationCardimplementation with the sharedCnCardcomponent, using its#icon,#labels, and footer slots for icon, status badges, and action linksconfigBadge--local,configBadge--external, etc.) toCnStatusBadgewith appropriatevariantandsolidpropsConfigurationsIndexlist/grid implementation withCnIndexPage, removing ~250 lines of duplicated layout, search, and pagination logicCnCardandCnStatusBadgestylesbased off of: #935
requires: ConductionNL/nextcloud-vue#18