Fix check_100_plus return value and missing i18n in cleanup cog#6782
Merged
Conversation
github-actions
Bot
added
the
Category: Cogs - Cleanup
Evanroby
changed the title
Jackenmen
added
the
Type: Bug
Jackenmen
changed the title
red-githubbot
Bot
added
the
Changelog Entry: Pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
this PR fixes 2 small bugs inside the cleanup cog, first one was reported by someone making testings for me, and tried to funnily do some impossibles things, this being that even when a number was above
2**63 - 1, bot would delete messages still, exemple with[p]cleanup bot 9999999999999999999. the second bug is two small i18n translating issues, I could see that the parentheses were wrongly put and fixed itHave the changes in this PR been tested?
Yes