Skip to content

[Audio]: Add button support for [p]now#6730

Open
Evanroby wants to merge 7 commits into
Cog-Creators:V3/developfrom
Evanroby:now-button
Open

[Audio]: Add button support for [p]now#6730
Evanroby wants to merge 7 commits into
Cog-Creators:V3/developfrom
Evanroby:now-button

Conversation

@Evanroby
Copy link
Copy Markdown
Contributor

@Evanroby Evanroby commented Apr 5, 2026

Description of the changes

Fixes #6133

Adds a button menu in utilities/menus directory, that is used on the [p]now command when [p]set usebuttons is true instead of the old reaction based menu

Have the changes in this PR been tested?

Yes

@github-actions github-actions Bot added the Category: Cogs - Audio This is related to the Audio cog. label Apr 5, 2026
@Jackenmen Jackenmen added this to the 3.5.25 milestone May 21, 2026
@Jackenmen Jackenmen self-assigned this May 23, 2026
@Jackenmen Jackenmen added the Type: Enhancement Something meant to enhance existing Red features. label May 26, 2026
Copy link
Copy Markdown
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the review comments, I do feel it's a bit weird that we stop accepting actions after one action, but admittedly, this is consistent with the behaviour of how it works with reactions-based [p]now, so it makes more sense to address this in a separate PR.

Comment thread redbot/cogs/audio/core/commands/controller.py Outdated
Comment thread redbot/cogs/audio/core/commands/controller.py Outdated
Comment thread redbot/cogs/audio/core/utilities/menus/now_playing.py
Comment thread redbot/cogs/audio/core/commands/controller.py
@Evanroby Evanroby requested a review from Jackenmen May 28, 2026 19:24
@Evanroby
Copy link
Copy Markdown
Contributor Author

Applied suggested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Cogs - Audio This is related to the Audio cog. Type: Enhancement Something meant to enhance existing Red features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[p]now doesn't use buttons when buttons are enabled

2 participants