Skip to content

Add note about CR timing to guide #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LonMcGregor merged 2 commits into from
Mar 11, 2026
Merged

Add note about CR timing to guide #1775

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
393a675
add note about CR timing
Mar 10, 2026
4ab00aa
Update org-cyf-guides/content/reviewing/trainee-pr-guide/index.md
LonMcGregor Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions org-cyf-guides/content/reviewing/trainee-pr-guide/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,11 @@ Responding to PR feedback is like a conversation: **listen**, **reply thoughtful
- If you don't understand a suggestion, ask for clarification.
- Example: _"Could you explain what you mean by simplifying this function?"_

5. **Respond Promptly**
- Our volunteers have a lot of PRs to keep on top of, so the quicker you respond, the sooner you will be finished with tasks
- But don't rush through, take the time to make sure your response meets what was being asked
- Try to respond within 2 days of a review, if something is blocking you, ask for help in slack

After you have taken action and replied to your feedback, you should add the **`Needs review`** label again, so the reviewer knows you are ready for your submission to be checked again.
When you make changes, make them in the same branch and don't create a new pull request each time.

Expand Down
Loading