London | 26-ITP-Jan | Kris Oldrini | Sprint 1 | Coursework#988
London | 26-ITP-Jan | Kris Oldrini | Sprint 1 | Coursework#988XiaoQuark wants to merge 19 commits intoCodeYourFuture:mainfrom
Conversation
XiaoQuark
added
the
Needs Review
Sprint-1/1-key-exercises/3-paths.js
Outdated
|
|
||
| const dir = ; | ||
| const ext = ; | ||
| const dir = filePath.slice(filePath.indexOf("/") + 1, lastSlashIndex); |
There was a problem hiding this comment.
Look at this properly console.log the result, I does not print out the dir part of the filePath variable
There was a problem hiding this comment.
Hi Emmanuel, thank you for your comment.
I see I'm missing the root in my dir, so I will get on to changing that. May I ask you about the last / just before the base? Would that also be part of the dir?
There was a problem hiding this comment.
Sorry @XiaoQuark can help with the questions, can only review, I will advice that you really reveiw the questions and what you need to do, so far, you are honestly doing a good job.
There was a problem hiding this comment.
No worries, I think I got it right this time.
The last / should be considered a separator and not part of the dir itself.
A-O-Emmanuel
added
Reviewed
XiaoQuark
added
the
Needs Review
A-O-Emmanuel
added
Complete
2 participants
Learners, PR Template
Self checklist
Changelist
1 Exercises
2 Errors
3 Interpret
4 Explore - Stretch 💪
Answered the questions in chrome.md and objects.md