Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 1 | Coursework#1087
Open
Darkidd77 wants to merge 13 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Mahammad Osman | Sprint 1 | Coursework#1087Darkidd77 wants to merge 13 commits intoCodeYourFuture:mainfrom
Darkidd77 wants to merge 13 commits intoCodeYourFuture:mainfrom
Conversation
…for better understanding
Darkidd77
added
the
Needs Review
cjyuan
reviewed
Feb 28, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Explanation looks good. I just have a question to challenge your understanding.
Comment on lines
+33
to
+34
| // 5. const pence = paddedPenceNumberString.substring(paddedPenceNumberString.length - 2).padEnd(2, "0"): | ||
| // extracts the pence part by taking the last two characters and pads it with trailing zeros if necessary, resulting in "99" |
Contributor
There was a problem hiding this comment.
Could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") from the code?
In other words, do we really need .padEnd(2, "0") in this script?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist