Glasgow | ITP-Jan-26 | Fattouma Ouannassi | Sprint 3 | Coursework 3 implement and rewrite#1080
Open
FAprogrammerO wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Conversation
…ment and rewrite <!-- You must title your PR like this: Region | Cohort | FirstName LastName | Sprint | Assignment Title For example, London | 25-ITP-May | Carol Owen | Sprint 1 | Alarm Clock Fill in the template below - remove any sections that don't apply. Complete the self checklist - replace each empty box in the checklist [ ] with a [x]. Add the label "Needs Review" and you will get review. Respond to volunteer reviews until the volunteer marks it as "Complete". Please note: if the PR template is not filled as described above, an automatic GitHub bot will give feedback in the "Conversation" tab of the pull request and not allow the "Needs Review" label to be added until it's fixed. --> ## Learners, PR Template Self checklist - [x] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title - [x] My changes meet the requirements of the task - [x] I have tested my changes - [x] My changes follow the [style guide](https://curriculum.codeyourfuture.io/guides/reviewing/style-guide/) ## Changelist This project (sprint 3) focuses on learning how to use JavaScript methods and test them. ## Questions /
FAprogrammerO
added
the
Needs Review
FAprogrammerO
changed the title
JaypeeLan
added
Review in progress
JaypeeLan
reviewed
Feb 27, 2026
| // TODO: Implement this function | ||
|
|
||
| // Implement a function getAngleType | ||
| function getAngleType(angle) { |
There was a problem hiding this comment.
This function assumes the input is always a valid number. You may want to guard against non-number values (e.g. "90", null, NaN) to avoid unexpected behaviour.
JaypeeLan
reviewed
Feb 27, 2026
|
|
||
| // Implement a function getAngleType | ||
| function getAngleType(angle) { | ||
| if (angle > 0 && angle < 90) { |
There was a problem hiding this comment.
The range checks work correctly, but the logic can be simplified. Try to see if you can reduce the number of checks, to make the code cleaner.
JaypeeLan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This project (sprint 3) focuses on learning how to use JavaScript methods and test them.
Questions
/