Birmingham | 26-ITP-Jan | Arunkumar Akilan | Sprint 1 | Structuring-and-Testing-Data Coursework/Sprint1 by arunkumarakilan · Pull Request #1017 · CodeYourFuture/Module-Structuring-and-Testing-Data

arunkumarakilan · 2026-02-22T14:12:08Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

This PR includes all my work for Sprint 1.

Completed exercises and explanations for:

Key exercises (count, initials, paths, random)
Mandatory errors
Mandatory interpret (percentage change, time format, pounds)
Stretch explore (chrome, objects)
Added explanations and comments where required
Tested code using Node and Chrome console
Explained logic and evaluation order where requested

Questions

No questions at this time.

Sprint-1/1-key-exercises/1-count.js

Sprint-1/1-key-exercises/4-random.js

cjyuan · 2026-03-02T05:49:14Z

Sprint-1/2-mandatory-errors/3.js

+const cardNumber = "4533787178994213";
+const last4Digits =  cardNumber.slice(-4);


Suppose you were not allowed to modify the statement const cardNumber = 4533787178994213;
(that is, keep the variable's value unchanged).
How would you modify the code (through type conversion) so that you can still use .slice(-4) to extract the last 4 digits from the given number.

.slice() only works on strings. Initially I didn’t know about type conversion, so I changed the number into a string and then used .slice(-4) to extract the last four digits.
A correct way would be converting the number to a string and then slicing it, for example:
Number(String(cardNumber).slice(-4)) or Number(cardNumber.toString().slice(-4)).

.slice() only works on strings, so we first convert the number to a string.
Then we slice the last four digits and convert it back to a number.

Number(String(cardNumber).slice(-4))

Sprint-1/2-mandatory-errors/4.js

Sprint-1/3-mandatory-interpret/3-to-pounds.js

Sprint-1/4-stretch-explore/objects.md

cjyuan · 2026-03-05T14:20:45Z

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

Reply to their feedback. (Can you practice this in this PR?)
- In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
  - You may find the suggestions in this PR Guide useful.
- Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
- Without this label, the reviewer would not know if your changes is ready to be reviewed.

arunkumarakilan · 2026-03-05T18:23:19Z

Sorry for not replying earlier to your two comments. I made the changes directly in VS Code and pushed them, but afterwards I couldn't find those two comments again to reply to them.

From my next PR onwards, I will make sure to reply to each piece of feedback and clearly explain the changes I made, as you suggested. Thank you for the guidance.

cjyuan · 2026-03-05T19:15:15Z

Can you practice responding to inline comments in this PR?

Birmingham | 26-ITP-Jan | Arunkumar Akilan | Sprint 1 | Structuring-and-Testing-Data Coursework/Sprint1 #1017 (comment)
Birmingham | 26-ITP-Jan | Arunkumar Akilan | Sprint 1 | Structuring-and-Testing-Data Coursework/Sprint1 #1017 (comment)
Birmingham | 26-ITP-Jan | Arunkumar Akilan | Sprint 1 | Structuring-and-Testing-Data Coursework/Sprint1 #1017 (comment)
Birmingham | 26-ITP-Jan | Arunkumar Akilan | Sprint 1 | Structuring-and-Testing-Data Coursework/Sprint1 #1017 (comment)
Birmingham | 26-ITP-Jan | Arunkumar Akilan | Sprint 1 | Structuring-and-Testing-Data Coursework/Sprint1 #1017 (comment)
Birmingham | 26-ITP-Jan | Arunkumar Akilan | Sprint 1 | Structuring-and-Testing-Data Coursework/Sprint1 #1017 (comment)

The response do not need to be detailed. Do look up (e.g., ask AI) what's the common practice when responding toe inline comments in a PR.

cjyuan · 2026-03-05T23:59:53Z

Part of the PR process involves learning how to respond to reviewers' comments. So far, not every comment was addressed, either through explanations or through changes made to the files.

cjyuan · 2026-03-06T21:39:57Z

I meant, reply directly in the comment box (the highlighted area in the pic) on GitHub (and on every comment).

cjyuan · 2026-03-07T09:03:44Z

@illicitonion ~~Can you step in on this PR? I do not understand why @arunkumarakilan keep changing the labels without responding my inline comments.~~

Resolved. It was a misunderstanding. The trainee was unware the responses were in "Pending" state.

arunkumarakilan · 2026-03-07T09:10:05Z

@illicitonion Can you step in on this PR? I do not understand why @arunkumarakilan keep changing the labels without responding my inline comments.

Hi, sorry for the confusion.

I have now replied to all the inline comments and updated the code where changes were suggested. I also resolved the conversations after addressing them.

If there is any comment I missed, please let me know and I will fix it. Thank you

arunkumarakilan · 2026-03-07T09:10:58Z

Hi, sorry for the confusion. I have now replied to all the inline comments and updated the code where changes were suggested. I also resolved the conversations after addressing them. If there is any comment I missed, please let me know and I will fix it. Thank you

…

On Sat, Mar 7, 2026 at 9:04 AM CJ Yuan ***@***.***> wrote: *cjyuan* left a comment (CodeYourFuture/Module-Structuring-and-Testing-Data#1017) <#1017 (comment)> @illicitonion <https://github.com/illicitonion> Can you step in on this PR? I do not understand why @arunkumarakilan <https://github.com/arunkumarakilan> keep changing the labels without addressing my requests. — Reply to this email directly, view it on GitHub <#1017 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BTZRSKFE2BI7WCBQCNSRLMD4PPQYLAVCNFSM6AAAAACV33ZZWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAMJWGAZDGNZTGY> . You are receiving this because you were mentioned.Message ID: <CodeYourFuture/Module-Structuring-and-Testing-Data/pull/1017/c4016023736@ github.com>

cjyuan · 2026-03-07T09:31:38Z

I can see that you have made changes in the files per my comment. What I was requesting is that you practice responding to inline comments. Even a short acknowledgement such as "Noted" or "Implemented" is enough (if the comment is not a question).

If you had left any response to my inline comments, can you check if they are marked "pending". Pending comments are comments that have not yet been submitted, and only you can see them.

cjyuan

One more question.

cjyuan · 2026-03-07T11:46:40Z

Sprint-1/2-mandatory-errors/3.js

 const cardNumber = 4533787178994213;
-const last4Digits = cardNumber.slice(-4);
+const last4Digits = Number(String(cardNumber).slice(-4));
+console.log(last4Digits);


Does your code output the value you expected ifcardNumber were 4533787178990001?

no so now i only convert to string and slice it thanks

cjyuan · 2026-03-07T13:06:39Z

Changes look good. Glad we figured out the pending comments.

arunkumarakilan added 15 commits February 14, 2026 15:55

complete initials

5f999c7

complete 1-count

90f27bb

complete paths

a5c9ea0

change the variable key word from const to let and fix the error

3de2b1d

i fix the error in this code

88670e7

Covert the number into string and fix the error

240da0e

identifier cannot start with number

1413d04

error fixed

ad59545

good

2589dc7

Fix the error and answer the question

14c0fe3

Answer all the question

4982dbf

described the purpose and rationale behind each step

0dc471c

Answer questions about alert, prompt, and console behaviour in chrome.md

a9067eb

docs: complete objects console exercise

0daa315

docs: break down random number expression and evaluation order

3af2171

This comment has been minimized.

Sign in to view

arunkumarakilan added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 22, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 22, 2026

arunkumarakilan added 2 commits February 22, 2026 14:44

fix: keep changes within Sprint-1 only

0d90b74

fix: remove prep changes from PR

73c30ee

arunkumarakilan added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 22, 2026

cjyuan reviewed Mar 2, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 2, 2026

arunkumarakilan added 3 commits March 5, 2026 10:07

Fix comments and add interval notation

21eed1b

Fix variable names and address review comments

51cc2d8

Fix review comments

d89e043

arunkumarakilan added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 5, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 5, 2026

arunkumarakilan added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 5, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 5, 2026

arunkumarakilan added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 5, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 6, 2026

arunkumarakilan added 2 commits March 6, 2026 08:53

fix: update console.log variable names to match renamed variables

4602c77

fix: extract last 4 digits using type conversion

77f51a4

arunkumarakilan added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 6, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 6, 2026

arunkumarakilan added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 7, 2026

cjyuan reviewed Mar 7, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 7, 2026

fixed

e6d8b17

arunkumarakilan added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 7, 2026

arunkumarakilan mentioned this pull request Mar 7, 2026

ITP-JAN-2026 | Structuring and testing data | Arunkumar Akilan arunkumarakilan/My-Coursework-Planner#66

Open

		const cardNumber = "4533787178994213";
		const last4Digits = cardNumber.slice(-4);

Uh oh!

Conversation

arunkumarakilan commented Feb 22, 2026

Learners, PR Template

Self checklist

Changelist

Questions

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

cjyuan Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

arunkumarakilan Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

arunkumarakilan Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan commented Mar 5, 2026

Uh oh!

arunkumarakilan commented Mar 5, 2026

Uh oh!

cjyuan commented Mar 5, 2026

Uh oh!

cjyuan commented Mar 5, 2026

Uh oh!

cjyuan commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjyuan commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arunkumarakilan commented Mar 7, 2026

Uh oh!

arunkumarakilan commented Mar 7, 2026 via email

Uh oh!

cjyuan commented Mar 7, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

arunkumarakilan Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Mar 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cjyuan commented Mar 6, 2026 •

edited

Loading

cjyuan commented Mar 7, 2026 •

edited

Loading