Glasgow | Prati Amalden | Module Complexity | Sprint 2 | Implement linked list#62
Glasgow | Prati Amalden | Module Complexity | Sprint 2 | Implement linked list#62PratiAmalden wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
PratiAmalden
added
the
Needs Review
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
bot
removed
the
Needs Review
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
PratiAmalden
changed the title
PratiAmalden
added
the
Needs Review
| else: | ||
| self.tail = handle.previous | ||
|
|
||
| handle.next = None |
There was a problem hiding this comment.
Why not also perform similar operations to the removed node in pop_tail()?
cjyuan
added
Reviewed
PratiAmalden
added
Needs Review
| self.tail = new_tail | ||
|
|
||
| old_tail.previous = None | ||
| old_tail.next = None |
There was a problem hiding this comment.
old_text.next was already None so line 42 is not needed.
Better still, delegate the job to remove() -- less code to maintain.
cjyuan
added
Complete
2 participants
No description provided.