Skip to content

London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 2 | Use precomputing for better performance#145

Open
aydaeslami wants to merge 1 commit intoCodeYourFuture:mainfrom
aydaeslami:Improve-code-with-precomputing
Open

London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 2 | Use precomputing for better performance#145
aydaeslami wants to merge 1 commit intoCodeYourFuture:mainfrom
aydaeslami:Improve-code-with-precomputing

Conversation

@aydaeslami
Copy link

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Introduced precomputing to reduce repeated work and improve performance of common_prefix and count_letters functions.

@aydaeslami aydaeslami added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 1, 2026
Copy link

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Can you use complexity to explain how the new implementation is better than the original implementation?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants