-
-
Notifications
You must be signed in to change notification settings - Fork 10
Feature/add theme #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add theme #827
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -19,6 +19,11 @@ services: | |||||
| links: | ||||||
| - db:db.docker.local | ||||||
| ports: | ||||||
| - 5000:5000 | ||||||
| - 5000 | ||||||
|
||||||
| - 5000 | |
| - "5000:5000" |
Copilot
AI
Mar 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The db-data volume is now declared as a named volume in docker-compose.yml, but the db service still mounts ./db-data:/data/db as a bind mount (a host directory). The named volume declaration and the bind mount are incompatible — the named volume db-data is never used by any service. If the intent was to switch from a bind mount to a managed named Docker volume, the db service's volumes entry should be changed from ./db-data:/data/db to db-data:/data/db. As-is, the volume declaration is unused.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,3 +31,33 @@ | |
| font-style: italic; | ||
| font-display: swap; | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: fusion-pixel; | ||
| src: url('../assets/fonts/fusion-pixel-10px-monospaced-zh_hant.woff2'); | ||
| font-weight: normal; | ||
| font-display: swap; | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: fusion-pixel; | ||
| src: url('../assets/fonts/fusion-pixel-10px-monospaced-zh_hant-bold.woff2'); | ||
| font-weight: bold; | ||
| font-display: swap; | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: fusion-pixel; | ||
| src: url('../assets/fonts/fusion-pixel-10px-monospaced-zh_hant-italic.woff2'); | ||
| font-weight: normal; | ||
| font-style: italic; | ||
| font-display: swap; | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: fusion-pixel; | ||
| src: url('../assets/fonts/fusion-pixel-10px-monospaced-zh_hant-bold-italic.woff2'); | ||
| font-weight: bold; | ||
| font-style: italic; | ||
| font-display: swap; | ||
| } | ||
|
Comment on lines
+42
to
+63
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,50 @@ | ||||||
|
|
||||||
| /** | ||||||
| Name: bit-fury | ||||||
| Deep gray background with blue accents | ||||||
| */ | ||||||
|
|
||||||
| .cm-s-bit-fury span.cm-meta { color: #da7b69; } | ||||||
| .cm-s-bit-fury span.cm-number { color: #aaeac1e6; } | ||||||
|
||||||
| .cm-s-bit-fury span.cm-number { color: #aaeac1e6; } | |
| .cm-s-bit-fury span.cm-number { color: #AAEAC1; } |
Copilot
AI
Mar 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the CSS selector: .CodeMirrir-linenumber should be .CodeMirror-linenumber (note "Mirrir" vs "Mirror"). The correct class name used by CodeMirror is .CodeMirror-linenumber, as correctly used in codemirror-myst.css. This means the line number color rule for the bit-fury theme will never apply.
| .cm-s-bit-fury .CodeMirrir-linenumber { color: #606366; } | |
| .cm-s-bit-fury .CodeMirror-linenumber { color: #606366; } |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,50 @@ | ||||||
|
|
||||||
| /** | ||||||
| Name: fury | ||||||
| Deep gray background with blue accents | ||||||
| */ | ||||||
|
|
||||||
| .cm-s-fury span.cm-meta { color: #da7b69; } | ||||||
| .cm-s-fury span.cm-number { color: #aaeac1e6; } | ||||||
|
||||||
| .cm-s-fury span.cm-number { color: #aaeac1e6; } | |
| .cm-s-fury span.cm-number { color: #AAEAC1; } |
Copilot
AI
Mar 7, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the CSS selector: .CodeMirrir-linenumber should be .CodeMirror-linenumber (note "Mirrir" vs "Mirror"). The correct class name used by CodeMirror is .CodeMirror-linenumber, as correctly used in the existing codemirror-myst.css file. This means the line number color rule for the fury theme will never apply.
| .cm-s-fury .CodeMirrir-linenumber { color: #606366; } | |
| .cm-s-fury .CodeMirror-linenumber { color: #606366; } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| html.bit-fury | ||
| { | ||
| --color-nano: #18283d; | ||
| --color-nanonotsolight: #2d3439; | ||
| --color-nanolight: #222e37; | ||
| --color-nanolightlight: #afafaf; | ||
| --color-white: #6d7f91; | ||
| --color-mystge: #527fab; | ||
| --color-mystlue: #2d688d; | ||
| --color-mysted: #4b97ed; | ||
| --color-mysteen: #2ec933; | ||
| --font-size-code: 1rem; | ||
| --font-size-small: 1rem; | ||
| --font-size-normal: 1.2rem; | ||
| --font-size-medium: 1.5rem; | ||
| --font-size-big: 3rem; | ||
| --border-radius: 0.3rem; | ||
| --break-small: 640px; | ||
| --font-stack: 'fusion-pixel', monospace; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| html.fury | ||
| { | ||
| --color-nano: #18283d; | ||
| --color-nanonotsolight: #2d3439; | ||
| --color-nanolight: #222e37; | ||
| --color-nanolightlight: #afafaf; | ||
| --color-white: #6d7f91; | ||
| --color-mystge: #527fab; | ||
| --color-mystlue: #2d688d; | ||
| --color-mysted: #4b97ed; | ||
| --color-mysteen: #2ec933; | ||
| --font-size-code: 1rem; | ||
| --font-size-small: 1rem; | ||
| --font-size-normal: 1.2rem; | ||
| --font-size-medium: 1.5rem; | ||
| --font-size-big: 3rem; | ||
| --border-radius: 0.3rem; | ||
| --break-small: 640px; | ||
| --font-stack: 'UbuntuMono', monospace; | ||
| } | ||
|
Comment on lines
+1
to
+20
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config example uses the key
guesslangUrl(camelCase) for the language detection URL, but the config parsing code inconfig.dprefers the snake_case keylanguage_detection_urland only falls back toguesslangUrl. This inconsistency means the example config is documenting the fallback (legacy) key rather than the preferred new key. The example should be updated to uselanguage_detection_urlto match the new preferred config key, or at a minimum show both options with a note about which is preferred.