Repository navigation
feat: run every closed feature the service lists - #162
Draft
Svilen-Stefanov wants to merge 6 commits into
Draft
Svilen-Stefanov wants to merge 6 commits into
Svilen-Stefanov wants to merge 6 commits into
Conversation
The review guide step becomes a generic runner: it reads GET /v1/features, collects the bundle once, posts one request per feature in parallel with only the inputs that feature names, and writes each answer to the artifact. A feature that never answered is written as skipped or failed, so a reader can tell not checked from nothing found. It computes nothing and names no feature, except the fallback to the guide alone for a service with no manifest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Only that feature's request carries it, within the size the service names. Past that, or with closed_features_source: false, the request goes without it and says why, so the feature reports what it could not check. Also lowers the bundle limit to what a Function URL really takes: base64 counts, so 5 MB was refused with a 413. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
CodeBoarding reviewStatus: 1 changed component See the full change in CodeBoarding. graph LR
n_action_support_scripts["action_support_scripts"]
classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
class n_action_support_scripts modified;
|
The run's llm, key and model now reach every feature, for each provider the service can call. A run on a provider it cannot reach makes no model call and is never sent to the hosted model. The manifest is read with the run's credentials. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
llm: hosted and license now refuse model, agent_model and parsing_model, with hosted_with_model and license_with_model. A run's own key uses agent_model, then model, as its analysis does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review guide step becomes a generic runner for CodeBoarding's closed features. It reads
GET /v1/features, collects the bundle once, posts one request per feature in parallel with the inputs that feature names, and writes each answer toclosed/<feature>.json.skippedorfailed, so a reader can tell "not checked" from "nothing found". One feature failing costs no other.review_guide.json.closed_features_source, defaulttrue. A feature can ask for the repository's source. Only its request carries it, within the service's size limit. Past that, or withfalse, the request goes without it and says why.llm, key andagent_model, thenmodel, reach every feature on each provider the service can call. A run on a provider it cannot reach, including any custom base URL, keeps its key on the runner, makes no model call and never falls back to the hosted model.hosted_with_modelandlicense_with_model. On CodeBoarding's key CodeBoarding picks the model, so a workflow that setsmodel,agent_modelorparsing_modelwithllm: hostedorlicensenow fails with a clear message. This can break a hand-edited workflow, and it is the only change here that can stop a run. The Action can only ask:gha_proxydoes not enforce it yet.scripts/review_guide.pyis nowscripts/closed_features.py. Inputreview_guide_urlkeeps its name, because workflows set it. The README's "never reaches CodeBoarding" line is corrected. Apart from those refusals, the step never fails the run. Nothing visible changes.🤖 Generated with Claude Code