Use underscores in integration-test tag keys and values#137
Merged
Conversation
Switch the integration test resource tags (managed-by, run-id, suite values) from dashes to underscores so the keys are valid identifiers in downstream tooling that treats `-` as an operator. Service names keep dashes since they are DNS-style identifiers, not tags. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
iskakaushik
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
managed-by→managed_by,run-id→run_id) and the associated values (clickhousectl-it,service-crud,postgres-crud) from dashes to underscores intests/integration/support.rs.tag:KEY=VALUEfilter strings (used by pre-create sweeps andCleanupRegistry) are updated in lockstep so listing and cleanup keep working.The
phase=patchedtag in the Postgres PATCH test never had a dash, so no change there. The only place tag literals live issupport.rs; the workflow file (.github/workflows/cloud-integration.yml) does not reference tag keys/values, so no CI changes are needed.Test plan
cargo build -p clickhouse-cloud-api --testspasses locally🤖 Generated with Claude Code